Skip to content

Conversation

@rutviksavsani
Copy link

Move the block template skip link from client-side injection to server-side HTML processing using the HTML API, while keeping the existing accessibility behaviour and minifying the CSS.

What this changes

  • Adds _block_template_skip_link_markup() to process the block template HTML:

    • Ensures the first <main> has an id (adds wp--skip-link--target if missing).
    • Inserts a single <a id="wp-skip-link" class="skip-link screen-reader-text"> before .wp-site-blocks.
    • Skips insertion when there is no <main> or when a skip link already exists.
  • Updates get_the_block_template_html() to run the rendered template through the new helper.

  • Refactors wp_enqueue_block_template_skip_link() to:

    • Remove the old JS-based DOM injection.
    • Minify the skip-link CSS as an inline style.
  • Preserves backward compatibility gating via the_block_template_skip_link and block-templates theme support.

  • Add tests for the new function as well.

Ticket

Trac ticket: https://core.trac.wordpress.org/ticket/64361


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props rutviksavsani, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this!

return '<div class="wp-site-blocks">' . $content . '</div>';
$template_html = '<div class="wp-site-blocks">' . $content . '</div>';

return _block_template_skip_link_markup( $template_html );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to consider inlining the logic instead of adding a new global function which is only used in one place.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter I initially considered inlining it but the for readability and testability, I went with a separate function and noticed in the codebase as well we follow the similar structure at many places.

If you feel we can still merge it into the main functions. I can do it as well.

@westonruter westonruter requested a review from dmsnell January 3, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants