-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Insert block template skip link via HTML API, minify CSS, remove JS. #10676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Insert block template skip link via HTML API, minify CSS, remove JS. #10676
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
westonruter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this!
| return '<div class="wp-site-blocks">' . $content . '</div>'; | ||
| $template_html = '<div class="wp-site-blocks">' . $content . '</div>'; | ||
|
|
||
| return _block_template_skip_link_markup( $template_html ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to consider inlining the logic instead of adding a new global function which is only used in one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@westonruter I initially considered inlining it but the for readability and testability, I went with a separate function and noticed in the codebase as well we follow the similar structure at many places.
If you feel we can still merge it into the main functions. I can do it as well.
Co-authored-by: Weston Ruter <[email protected]>
Co-authored-by: Weston Ruter <[email protected]>
Co-authored-by: Weston Ruter <[email protected]>
Co-authored-by: Weston Ruter <[email protected]>
Co-authored-by: Weston Ruter <[email protected]>
Move the block template skip link from client-side injection to server-side HTML processing using the HTML API, while keeping the existing accessibility behaviour and minifying the CSS.
What this changes
Adds
_block_template_skip_link_markup()to process the block template HTML:<main>has an id (addswp--skip-link--targetif missing).<a id="wp-skip-link" class="skip-link screen-reader-text">before.wp-site-blocks.<main>or when a skip link already exists.Updates
get_the_block_template_html()to run the rendered template through the new helper.Refactors
wp_enqueue_block_template_skip_link()to:Preserves backward compatibility gating via
the_block_template_skip_linkand block-templates theme support.Add tests for the new function as well.
Ticket
Trac ticket: https://core.trac.wordpress.org/ticket/64361
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.