Use null coalescing operator (`??`) for remaining instances of `isset()` ternaries #10654

westonruter · 2025-12-23T02:56:02Z

This is a follow-up up to r61403.

I used PHPStorm's regex search and replace with the pattern ((?:return|echo|$|,|\s=|\.=|=>)\s*)isset\(\s*(.+?)\s*$\s*\?\s*\2(\s*): and the replacement $1$2$3??.

Paths omitted from replacement:

src/wp-content/themes (since older versions of PHP may need to be supported)
src/wp-includes/class-wp-block-parser-frame.php (synced from Gutenberg)
src/wp-includes/ID3 (external library)
src/wp-includes/blocks (synced from Gutenberg)

Trac ticket: https://core.trac.wordpress.org/ticket/58874
Trac ticket: https://core.trac.wordpress.org/ticket/63430

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2025-12-23T02:56:13Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-12-23T03:12:12Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

…enberg

… place of `isset()` in ternaries. Developed as a subset of #10654 Follow-up to [61404], [61403]. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61424 602fd350-edb4-49c9-b593-d223f7449a82

* trunk: Code Modernization: Update `tests` to use null coalescing operator in place of `isset()` in ternaries.

… place of `isset()` in ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Follow-up to [61404], [61403]. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61424 git-svn-id: http://core.svn.wordpress.org/trunk@60736 1a063a9b-81f0-0310-95a4-ce76da25c4cd

… place of `isset()` in ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Follow-up to [61404], [61403]. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61424 git-svn-id: https://core.svn.wordpress.org/trunk@60736 1a063a9b-81f0-0310-95a4-ce76da25c4cd

Co-authored-by: Colin Stewart <[email protected]>

…f `isset()` in ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61429 602fd350-edb4-49c9-b593-d223f7449a82

…ss-develop into trac-63430-null-coalescing * 'trunk' of https://github.com/WordPress/wordpress-develop: Code Modernization: REST API: Use null coalescing operator in place of `isset()` in ternaries.

…f `isset()` in ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61429 git-svn-id: http://core.svn.wordpress.org/trunk@60741 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…f `isset()` in ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61429 git-svn-id: https://core.svn.wordpress.org/trunk@60741 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…ead of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61430 602fd350-edb4-49c9-b593-d223f7449a82

* trunk: Code Modernization: Block Supports: Use null coalescing operator instead of `isset()` ternaries.

…ead of `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61430 git-svn-id: http://core.svn.wordpress.org/trunk@60742 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…ead of `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61430 git-svn-id: https://core.svn.wordpress.org/trunk@60742 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61431 602fd350-edb4-49c9-b593-d223f7449a82

…isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61431 git-svn-id: https://core.svn.wordpress.org/trunk@60743 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…f `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61433 git-svn-id: https://core.svn.wordpress.org/trunk@60745 1a063a9b-81f0-0310-95a4-ce76da25c4cd

… `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61434 602fd350-edb4-49c9-b593-d223f7449a82

… `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61434 git-svn-id: http://core.svn.wordpress.org/trunk@60746 1a063a9b-81f0-0310-95a4-ce76da25c4cd

… `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61434 git-svn-id: https://core.svn.wordpress.org/trunk@60746 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…set()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61435 602fd350-edb4-49c9-b593-d223f7449a82

…set()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61435 git-svn-id: http://core.svn.wordpress.org/trunk@60747 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61436 602fd350-edb4-49c9-b593-d223f7449a82

…set()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61435 git-svn-id: https://core.svn.wordpress.org/trunk@60747 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…of `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61436 git-svn-id: http://core.svn.wordpress.org/trunk@60748 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…of `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61436 git-svn-id: https://core.svn.wordpress.org/trunk@60748 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…ad of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61442 602fd350-edb4-49c9-b593-d223f7449a82

…ad of `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61442 git-svn-id: http://core.svn.wordpress.org/trunk@60754 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…ad of `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61442 git-svn-id: https://core.svn.wordpress.org/trunk@60754 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…ss-develop into trac-63430-null-coalescing * 'trunk' of https://github.com/WordPress/wordpress-develop: Code Modernization: Script Loader: Use null coalescing operator instead of `isset()` ternaries.

…ead of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61443 602fd350-edb4-49c9-b593-d223f7449a82

…ss-develop into trac-63430-null-coalescing * 'trunk' of https://github.com/WordPress/wordpress-develop: Code Modernization: Bootstrap/Load: Use null coalescing operator instead of `isset()` ternaries.

…ead of `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61443 git-svn-id: http://core.svn.wordpress.org/trunk@60755 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…ead of `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61443 git-svn-id: https://core.svn.wordpress.org/trunk@60755 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…Use null coalescing operator instead of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61444 602fd350-edb4-49c9-b593-d223f7449a82

…ss-develop into trac-63430-null-coalescing * 'trunk' of https://github.com/WordPress/wordpress-develop: Code Modernization: Site Health, Permalinks, I18N, Users, Multisite: Use null coalescing operator instead of `isset()` ternaries.

…Use null coalescing operator instead of `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61444 git-svn-id: http://core.svn.wordpress.org/trunk@60756 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…Use null coalescing operator instead of `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61444 git-svn-id: https://core.svn.wordpress.org/trunk@60756 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…ery, General: Use null coalescing operator instead of `isset()` ternaries. Developed as a subset of #10654 Initially developed in #4886 Follow-up to [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. git-svn-id: https://develop.svn.wordpress.org/trunk@61445 602fd350-edb4-49c9-b593-d223f7449a82

…ery, General: Use null coalescing operator instead of `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61445 git-svn-id: http://core.svn.wordpress.org/trunk@60757 1a063a9b-81f0-0310-95a4-ce76da25c4cd

…ery, General: Use null coalescing operator instead of `isset()` ternaries. Developed as a subset of WordPress/wordpress-develop#10654 Initially developed in WordPress/wordpress-develop#4886 Follow-up to [61444], [61443], [61442], [61436], [61435], [61434], [61403], [61433], [61432], [61431], [61430], [61429], [61424], [61404], [61403]. Props costdev, westonruter. See #58874, #63430. Built from https://develop.svn.wordpress.org/trunk@61445 git-svn-id: https://core.svn.wordpress.org/trunk@60757 1a063a9b-81f0-0310-95a4-ce76da25c4cd

Use null coalescing operator for remaining uses of isset()

87f0388

westonruter changed the title ~~Use null coalescing operator for remaining uses of isset()~~ Use null coalescing operator (??) for remaining uses of isset() Dec 23, 2025

westonruter mentioned this pull request Dec 23, 2025

Code Modernization: Replace some ternaries with null coalescing operator. #4886

Open

westonruter added 5 commits January 2, 2026 18:18

Merge branch 'trunk' into trac-63430-null-coalescing

9021455

Replace remaining instances outside of ID3 and block-library

401b338

Revert erroneous replacements

5a69db2

Revert change to class-wp-block-parser-frame.php since comes from Gut…

59ccd14

…enberg

Move line-initial null coalescing operator to end of previous line

362c178

Merge branch 'trunk' @ r61424 into trac-63430-null-coalescing

0be1779

* trunk: Code Modernization: Update `tests` to use null coalescing operator in place of `isset()` in ternaries.

westonruter changed the title ~~Use null coalescing operator (??) for remaining uses of isset()~~ Use null coalescing operator (??) for remaining instances of isset() ternaries Jan 3, 2026

westonruter and others added 2 commits January 4, 2026 20:02

Merge branch 'trunk' into trac-63430-null-coalescing

d4ef0ca

Apply REST API changes from WordPress@f310c89

d37d630

Co-authored-by: Colin Stewart <[email protected]>

Merge branch 'trunk' @ r61429 of https://github.com/WordPress/wordpre…

357f21d

…ss-develop into trac-63430-null-coalescing * 'trunk' of https://github.com/WordPress/wordpress-develop: Code Modernization: REST API: Use null coalescing operator in place of `isset()` in ternaries.

Merge branch 'trunk' @ r61430 into trac-63430-null-coalescing

b9cd4f7

* trunk: Code Modernization: Block Supports: Use null coalescing operator instead of `isset()` ternaries.

Remove needless parentheses and line breaks

a4e428e

Fix syntax error

35f17d6

Merge branch 'trunk' @ r61431 into trac-63430-null-coalescing

ac277b2

Merge branch 'trunk' @ r61435 into trac-63430-null-coalescing

ef8a226

Merge branch 'trunk' @ r61436 into trac-63430-null-coalescing

13bacde

Merge branch 'trunk' into trac-63430-null-coalescing

dabecc8

Merge branch 'trunk' @ r61442 of https://github.com/WordPress/wordpre…

17ff1af

…ss-develop into trac-63430-null-coalescing * 'trunk' of https://github.com/WordPress/wordpress-develop: Code Modernization: Script Loader: Use null coalescing operator instead of `isset()` ternaries.

Merge branch 'trunk' @ r61443 of https://github.com/WordPress/wordpre…

802c25f

…ss-develop into trac-63430-null-coalescing * 'trunk' of https://github.com/WordPress/wordpress-develop: Code Modernization: Bootstrap/Load: Use null coalescing operator instead of `isset()` ternaries.

Remove extraneous parentheses

b20e3ea

Merge branch 'trunk' @ r61445 into trac-63430-null-coalescing

96989e7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use null coalescing operator (`??`) for remaining instances of `isset()` ternaries #10654

Use null coalescing operator (`??`) for remaining instances of `isset()` ternaries #10654

Uh oh!

westonruter commented Dec 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Use null coalescing operator (??) for remaining instances of isset() ternaries #10654

Are you sure you want to change the base?

Use null coalescing operator (??) for remaining instances of isset() ternaries #10654

Uh oh!

Conversation

westonruter commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 23, 2025

Uh oh!

github-actions bot commented Dec 23, 2025

Test using WordPress Playground

Some things to be aware of

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Use null coalescing operator (`??`) for remaining instances of `isset()` ternaries #10654

Use null coalescing operator (`??`) for remaining instances of `isset()` ternaries #10654

westonruter commented Dec 23, 2025 •

edited

Loading