This repository was archived by the owner on Aug 13, 2023. It is now read-only.
Create a new user object in WhosPcRpl if it does not exist yet#166
Open
NanoSector wants to merge 1 commit intomasterfrom
Open
Create a new user object in WhosPcRpl if it does not exist yet#166NanoSector wants to merge 1 commit intomasterfrom
NanoSector wants to merge 1 commit intomasterfrom
Conversation
Member
Author
|
Upon further checks, the user object should be created upon the NamReply message. This change becomes redundant and the original behaviour might even be useful as a bug check. I'll leave this open for now, it's probably best to investigate the proper chain of messages before acting on this. The issue originally linked had a deeper bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should increase reliability with hopefully no side effects. All user information should be in the WhosPcRpl message and thus creating users at this stage should be safe.