Skip to content

Fix dev server output #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camillobruni wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −8
Open

Fix dev server output #252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49cd82c
format
camillobruni Jan 13, 2026
9bac0c8
formatting
camillobruni Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions tests/server.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,27 +30,39 @@ import LocalWebServer from "local-web-server";
const ROOT_DIR = path.join(process.cwd(), "./");

export const optionDefinitions = [
{ name: "port", type: Number, defaultValue: 8010, description: "Set the test-server port, The default value is 8010." },
{ name: "verbose", type: Boolean, defaultValue: false, description: "Log all requests set to the server." },
{
name: "port",
type: Number,
defaultValue: 8010,
description: "Set the test-server port, The default value is 8010.",
},
{
name: "quiet",
alias: "q",
type: Boolean,
defaultValue: false,
description: "Silence the server output.",
},
];

export async function serve({ port, verbose }) {
if (!port)
throw new Error("Port is required");
export async function serve(options) {
let { port, quiet } = options;
Copy link
Contributor

@kmiller68 kmiller68 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Why make this change? we don't use options anywhere.


if (!port) throw new Error("Port is required");

const ws = await LocalWebServer.create({
port: port,
directory: ROOT_DIR,
corsOpenerPolicy: "same-origin",
corsEmbedderPolicy: "require-corp",
logFormat: verbose ? "dev" : "none",
logFormat: quiet ? undefined : "dev",
});
console.log(`Server started on http://localhost:${port}`);
process.on("exit", () => ws.server.close());
return {
close() {
ws.server.close();
}
},
};
}

Expand All @@ -59,5 +71,6 @@ function main() {
serve(options);
}

if (esMain(import.meta))
if (esMain(import.meta)) {
main();
}
Loading