Skip to content

bugfix ArrayGene.doesExist #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcuri82 merged 2 commits into from
Mar 12, 2026
Merged

bugfix ArrayGene.doesExist #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c68e180
Refined `ArrayGene.doesExist` to compare gene types before value comp…
jgaleotti Mar 11, 2026
85d2f00
Merge remote-tracking branch 'origin/master' into fix-arraygene-doesE…
jgaleotti Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/kotlin/org/evomaster/core/search/gene/collection/ArrayGene.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,10 @@ class ArrayGene<T>(
*/
fun doesExist(gene: T): Boolean{
if (!isElementApplicableToUniqueCheck(ParamUtil.getValueGene(gene))) return false
return elements.any { ParamUtil.getValueGene(it).containsSameValueAs(ParamUtil.getValueGene(gene)) }
return elements.any {
it.getLeafGene().javaClass == gene.getLeafGene().javaClass &&
it.getLeafGene().containsSameValueAs(gene.getLeafGene())
}
}

/**
Expand Down
30 changes: 30 additions & 0 deletions core/src/test/kotlin/org/evomaster/core/search/gene/ArrayGeneTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,15 @@ package org.evomaster.core.search.gene

import org.evomaster.core.search.gene.collection.ArrayGene
import org.evomaster.core.search.gene.collection.EnumGene
import org.evomaster.core.search.gene.numeric.BigIntegerGene
import org.evomaster.core.search.gene.numeric.IntegerGene
import org.evomaster.core.search.gene.numeric.LongGene
import org.evomaster.core.search.gene.string.StringGene
import org.evomaster.core.search.gene.utils.GeneUtils
import org.evomaster.core.search.gene.wrapper.ChoiceGene
import org.evomaster.core.search.service.Randomness
import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.Assertions.assertFalse
import org.junit.jupiter.api.Assertions.assertTrue
import org.junit.jupiter.api.Test
import org.junit.jupiter.api.assertThrows
Expand Down Expand Up @@ -207,4 +210,31 @@ class ArrayGeneTest {
assertTrue(!xmlOutput.contains("]"), "XML should not contain square brackets")
assertTrue(!xmlOutput.contains(", "), "XML must not contain commas with spaces")
}

@Test
fun testDoesExistWithDifferentNumericGeneTypes() {
val bigIntegerGeneValue = java.math.BigInteger.valueOf(42L)
val bigIntegerGene = BigIntegerGene("bigInt", bigIntegerGeneValue)

val integerGeneValue = 42
val integerGene = IntegerGene("int", integerGeneValue)

val choiceGene = ChoiceGene("choice", listOf(bigIntegerGene, integerGene))

val arrayWithChoiceGenes = ArrayGene(
"arrayOfChoiceGenes",
template = ChoiceGene("template", listOf(bigIntegerGene, integerGene)),
elements = mutableListOf(choiceGene)
)

val anotherChoiceGene = ChoiceGene("choice", listOf(bigIntegerGene, integerGene))

choiceGene.selectActiveGene(0)
anotherChoiceGene.selectActiveGene(1)

assertFalse(arrayWithChoiceGenes.doesExist(anotherChoiceGene))

}


}
Loading