fix: prevent list_index variable shadowing in fix_incorrect_toc #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list_index variable (original TOC index) was being overwritten by the page loop iterator, causing results to be written back to wrong index positions when updating toc_with_page_number. Rename the loop variable to page_list_idx to avoid shadowing.
- Add docstring documenting parameters, returns, and constraints - Validate start_index >= 1 (raise ValueError if invalid) - Log page_list alignment assumptions for debugging - Track and warn when pages are skipped due to bounds issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66
Summary
Fix variable shadowing bug in
fix_incorrect_toc()that caused updates to be written to wrong array positions.Problem
The
list_indexvariable (original TOC index) was being overwritten inside the page content loop. When results were written back totoc_with_page_number, they went to the wrong index.Change
Rename loop variable from
list_indextopage_list_idxto avoid shadowing the original TOC index.Impact
Before: If fixing TOC item at index 5, but page loop ended at index 19, the update would go to position 19.
After: Update correctly goes to position 5.