refactor: major code quality and architecture improvements#327
Open
CloudWaddie wants to merge 1 commit intoVeNoMouS:masterfrom
Open
refactor: major code quality and architecture improvements#327CloudWaddie wants to merge 1 commit intoVeNoMouS:masterfrom
CloudWaddie wants to merge 1 commit intoVeNoMouS:masterfrom
Conversation
- Split monolithic CloudScraper class into focused modules: - session_manager.py: Session health, refresh, cookie management - request_throttler.py: Rate limiting, concurrency, TLS cipher rotation - base.py: Abstract base class for challenge handlers - constants.py: Centralized constants - Code quality improvements: - Added comprehensive type hints to all public methods - Fixed bare except clauses and empty catches - Replaced magic numbers with named constants - Pre-compiled regex patterns at module level - Removed Python 2 compatibility code - Cached browsers.json at initialization - Expanded test suite from 221 to 567 lines - Rewrote README with better documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes major refactoring and improvements to cloudscraper:
Architecture Refactoring
session_manager.py: Session health, refresh, cookie managementrequest_throttler.py: Rate limiting, concurrency, TLS cipher rotationbase.py: Abstract base class for challenge handlersconstants.py: Centralized constantsCode Quality Improvements
Testing
Documentation