Skip to content

chore: remove standalone relay #3893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EmandM merged 1 commit into from
Mar 12, 2026
+1 −127
Merged

chore: remove standalone relay #3893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 0 additions & 118 deletions com.unity.netcode.gameobjects/Editor/NetworkManagerRelayIntegration.cs
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions com.unity.netcode.gameobjects/Editor/NetworkManagerRelayIntegration.cs.meta
View file
Open in desktop

This file was deleted.

7 changes: 1 addition & 6 deletions com.unity.netcode.gameobjects/Editor/Unity.Netcode.Editor.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,11 @@
"expression": "",
"define": "COM_UNITY_MODULES_PHYSICS2D"
},
{
"name": "com.unity.services.relay",
"expression": "1.0",
"define": "RELAY_SDK_INSTALLED"
Copy link
Member

@michalChrobot michalChrobot Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the ticket there few possible answers so I just wonder what is the final conclusion, why we don't need this define?

Copy link
Member Author

@EmandM EmandM Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The com.unity.services.relay package is very deprecated. The new package is com.unity.services.multiplayer. I'm also not convinced this file was doing anything. There were changes made to the NetworkManagerEditor when this file was landed. I think this file has extension methods that were used by stuff that has since been removed from the editor

Copy link
Member

@NoelStephensUnity NoelStephensUnity Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalChrobot
I did a double take too because the relay package is still "functional" in 6000.70f1.
Just as a personal sanity check, I went ahead and:

  • Created a new project with 6000.0.70f1.
  • Installed Relay (this is what used to create the RELAY_SDK_INSTALLED define).
  • Installed NG0 v2.1.0. (using Develop-2.0.0)
  • Added a NetworkManager with UnityTransport to the SampleScene.

The results where:

  • Relay evidently still works but is obviously marked as deprecated with information on what to upgrade to.
  • Only with the deprecated relay package installed does the RELAY_SDK_INSTALLED get defined.
    • With this defined, NetworkManagerRelayIntegration becomes declared.
    • This file is the only file that RELAY_SDK_INSTALLED is used.
      • It used to be there was additional code in the NetworkManager.
        • In v1.x.x, here is where it is used.
          • This defines RELAY_INTEGRATION_AVAILABLE (v1.x.x only) which then exposed the "helper tool".
          • RELAY_INTEGRATION_AVAILABLE does not exist in v2.x.x.
  • Nothing in NGO references the NetworkManagerRelayIntegration.
    • The visual part was pulled out awhile back, but it looks like this was not removed with it.
image

Looks like a very safe removal and really should have been removed when the relay helper tool was removed awhile back.

👍

Copy link
Member

@michalChrobot michalChrobot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, totally agree then, especially that as far as I remember BossRoom/Asteroids are using the updated package

},
{
"name": "com.unity.services.multiplayer",
"expression": "0.2.0",
"define": "MULTIPLAYER_SERVICES_SDK_INSTALLED"
}
],
"noEngineReferences": false
}
}