Open
Conversation
79ab94d to
cdc8db7
Compare
e8bfe25 to
60ff856
Compare
a6ad843 to
e2ea2a1
Compare
|
much appreciated! I hope someone at Unity will review this quickly! |
|
Would love to see this potentially get some love and support! Would really help to have V-HACD collision meshes be available with mesh colliders as full package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Update to the latest kmammou/v-hacd.
v-hacd version 4 changed to being a single-header file, including both function signatures and implementation code. This was copied to
src/inc/VHACD.h.src/dllhas the updateddll.cpp. The biggest difference was to define our ownConvexHullstruct. Since the new version changedIVHACD::ConvexHullto usestd::vectorand nested objects (e.g.std::vector<VHACD::Vertex>), I made a simplerstruct ConvexHullCSharpwith pointers and lengths to the points and triangles. This makes it easier to interop with C#.This does mean I'm copying the
IVHACD::ConvexHulls intoConvexHullCSharpstructs (I did take care of deallocating the memory used by this after it's consumed). But this step is not a bottleneck for generation-performance -- the actual hull generation is where almost all of the time is spent, and that still happens on the C++ side only.I've also updated
VHACD.csto match the newParameters, and free the memory allocated by the copying explained above. There are tooltips for all the params:I've updated the CMake setup to have only one
CMakeLists.txtto build the shared libraries.Finally, I've deleted
src/test,bin, andbin_no_ocl, as they're not needed in this package.Useful links (GitHub issues, JIRA tickets, forum threads, etc.)
Types of change(s)
Update dependency.
Testing and Verification
Please describe the tests that you ran to verify your changes. Please also provide instructions and Unity project files as appropriate so we can reproduce the test environment.
Test Configuration:
.dylibon Mac, but it builds with the same CMake config, so I assume it works as it did before)Checklist
devbranchdevbranchOther comments