fix: Correct line in hyperlink to swapAndAddLiquidity#40
Open
CalabashSquash wants to merge 1 commit intoUniswap:mainfrom
Open
fix: Correct line in hyperlink to swapAndAddLiquidity#40CalabashSquash wants to merge 1 commit intoUniswap:mainfrom
CalabashSquash wants to merge 1 commit intoUniswap:mainfrom
Conversation
Collaborator
|
@dannydaniil It looks like there are some inconsistencies here on all V3 examples - some link to specific lines and others link just to the file. Thoughts on standardizing just to file to avoid these link issues as any updates occur? |
Collaborator
dannythedawger
left a comment
dannythedawger
left a comment
There was a problem hiding this comment.
@CalabashSquash feel free to remove the line and we should be good to merge!
|
``v3-sdk/swap-and-add-liquidity/src/libs/liquidity.ts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current hyperlink in
v3-sdk/swap-and-add-liquidity/README.mdlinks to the wrong line in a file.Changes
Update the code line in hyperlink.