doc: rdp requirements #2283
doc: rdp requirements #2283
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the requirements documentation page by adding RDP viewer information alongside existing Spice client instructions. The changes organize the requirements by operating system (Linux, Windows, macOS) and display protocol (RDP, SPICE) in a more structured format using lists.
Changes:
- Added RDP client installation instructions for Linux (remmina with RDP plugin)
- Added RDP availability notes for Windows and macOS (installed by default)
- Reorganized content into structured lists for better readability
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
templates/main/requirements.html.ep
Outdated
|
|
||
| <i class="fab fa-windows fa-3x" aria-hidden="true"> Microsoft Windows </i>©<br><br><p> <%=l 'You will need to install' %> | ||
| <li> | ||
| <b>Spice:</b> <%=l 'For Spice redirection you will need to install' %><a target=_blank href="https://virt-manager.org/download.html"> VirtViewer<i class="fa fa-link" aria-hidden="true"></i></a> <%=l 'in your computer.' %><br> |
There was a problem hiding this comment.
The indentation on this line is inconsistent with the rest of the file. The Spice: tag and the following content should be properly indented to align with the content inside the
templates/main/requirements.html.ep
Outdated
| <%=l 'Another tool that works well with SPICE is remmina.' %> | ||
| <pre>sudo apt-get install remmina</pre> |
There was a problem hiding this comment.
There's a duplicate/conflicting recommendation here. Line 19 already recommends installing 'remmina remmina-plugin-rdp' for RDP support, and now line 27 recommends installing just 'remmina' again for SPICE. This creates confusion about whether remmina is needed for RDP, SPICE, or both. Consider clarifying that remmina with the rdp plugin (already mentioned for RDP) also supports SPICE, or specify that different plugins are needed.
templates/main/requirements.html.ep
Outdated
| <%=l 'You will need to install' %> | ||
| <a target=_blank href="https://virt-manager.org/download.html">VirtViewer<i class="fa fa-link" aria-hidden="true"></i> </a> | ||
|
|
||
| <%=l 'and USB drivers (' %><a href="https://www.spice-space.org/download/windows/usbdk/UsbDk_1.0.22_x64.msi">64 <i class="fa fa-download" aria-hidden="true"></i> </a><%=l 'or' %><a href="https://www.spice-space.org/download/windows/usbdk/UsbDk_1.0.22_x86.msi"> 32 <i class="fa fa-download" aria-hidden="true"></i> </a><%=l 'bits) in your computer.' %></p> |
There was a problem hiding this comment.
There's an unclosed
tag on line 39. The opening tag exists but there's no corresponding closing
tag before the nexttag on line 41. This creates invalid HTML structure. Either remove the opening
tag on line 39 or add a proper closing tag before line 41.
templates/main/requirements.html.ep
Outdated
| <li><b>RDP:</b> | ||
| <%=l 'RDP works out of the box because the client is installed by default.' %> |
There was a problem hiding this comment.
The statement that RDP works out of the box on macOS is misleading. While macOS does come with built-in screen sharing, it does not include a Microsoft RDP client by default. Users typically need to install Microsoft Remote Desktop from the Mac App Store or use third-party RDP clients. This information should be corrected to avoid confusion.
Added information about RDP viewers