Skip to content

Conversation

@plamenivanov91
Copy link
Contributor

No description provided.

@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Jan 19, 2026

🧹 Preview deployment cleaned up: https://pr-12931--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 19, 2026 17:41 Inactive
@kgogov kgogov self-requested a review January 21, 2026 14:09
@kgogov
Copy link
Contributor

kgogov commented Jan 21, 2026

Hello @plamenivanov91,

I reviewed your changes, and overall the text‑streaming imitation in the sample works similarly to the AI QuickPrompt sample. However, there is one detail that stood out to me.

When we click the "Generate" button in QuickPrompt, the busy indicator appears first, and after a short delay the text starts streaming. In contrast, in GuidedPrompt we don’t see this behavior.

With GuidedPrompt, when clicking "Generate", a dialog opens where we configure how we want the text to be generated. After clicking "Apply", the text begins streaming immediately, and only after some time the busy indicator appears.

I know this may seem minor, but I think it would be good for both samples to behave consistently. In my opinion, the effect in QuickPrompt better simulates the real interaction experience with an AI chat.

Copy link
Contributor

@kgogov kgogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: try to make the busy indicator behave the same way as in the AI QuickPrompt sample.

@plamenivanov91
Copy link
Contributor Author

Suggestion: try to make the busy indicator behave the same way as in the AI QuickPrompt sample.

Thanks for the review. Yes, in the quick prompt there is a 2s delay before the text streaming begins to achieve the effect you mentioned. So I did something similar in this PR.

@plamenivanov91 plamenivanov91 requested a review from kgogov January 21, 2026 15:31
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 21, 2026 15:36 Inactive
@plamenivanov91 plamenivanov91 merged commit 67088a0 into main Jan 21, 2026
21 of 22 checks passed
@plamenivanov91 plamenivanov91 deleted the guided-prompt-text-streaming branch January 21, 2026 16:32
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview January 21, 2026 16:32 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants