fix(ui5-dialog): events are attached only if the dialog is open #12929
+159
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
🚀 Deployed on https://pr-12929--ui5-webcomponents-preview.netlify.app |
Stoev
reviewed
Jan 22, 2026
Stoev
left a comment
Stoev
left a comment
There was a problem hiding this comment.
fix(ui5-dialog): attach events only when the dialog is open
I'd recommend putting a full stop at the end of each inline comment sentence. Since it's an inline comment, I'd only leave this as a suggestion here.
| </> | ||
| ); | ||
|
|
||
| // Open dialog first time |
There was a problem hiding this comment.
Suggested change
| // Open dialog first time | |
| // Open dialog for the first time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12809