Allow getting data by subclasses#68
Allow getting data by subclasses#68norinorin wants to merge 2 commits intoTop-gg-Community:masterfrom
Conversation
rf20008
left a comment
rf20008
left a comment
There was a problem hiding this comment.
LGTM (but I don't see the point. This might also be a breaking change)
You're not wrong, I kinda had a use case but I don't think it's practical (that's why this is still a draft). Though don't worry about the breaking change, we're indeed doing breaking changes. We've bumped the major version and it's still alpha anyway. |
|
@norinorin Do you plan on advancing further with this PR by any chance? |
|
Sorry I missed your comment. It's been a few years, and I don't remember the specifics of this PR (had to be related to one of my local projects). I must've left it in a usable state but forgot to remove the draft status. Feel free to merge it or close it as you see fit, if there is even an active maintainer that is. |
3 participants
Proposed Changes
Allow getting data by subclasses. The time complexity is supposedly O(n) on the first lookup and O(1) afterwards as the first result got cached.