Skip to content

Conversation

@guymarshall
Copy link

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)
  • Typo correction

Description of the changes in your PR

  • replace "2k" with "2.5k" and "2K" with "2.5K" to fix common mistake
  • The "k" in a resolution is a rough estimation of the longest dimension e.g. 5k is 51202880, 4k is 38402160, 2.5k is 25601440, 2k is 19201080 and so on. There is a common misconception that 2560*1440 or 1440p is actually 2k but it isn't.

Before/After Screenshots/Screen Record

  • Before:
  • After:

Due diligence

@github-actions github-actions bot added the size/large PRs with less than 750 changed lines label Dec 2, 2025
@TobiGr
Copy link
Contributor

TobiGr commented Dec 3, 2025

hm. displaying 2.5K might irritate the users. I think we should check in the extractor if we can find streams with the correct resolution. It makes no sense to me to use resolution descriptions that are different from the ones the services use.

@guymarshall
Copy link
Author

Good points. Maybe we label it as 1440p like on the desktop website?
Screenshot from 2025-12-03 17-56-45

@TobiGr
Copy link
Contributor

TobiGr commented Dec 5, 2025

Sounds good

@TobiGr TobiGr added player Issues related to any player (main, popup and background) localisation / translation Everything that has to do with translations or Weblate labels Dec 5, 2025
Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@TobiGr TobiGr changed the title UPDATE: Replace 2k and 2K with 2.5k and 2.5K to fix common mistake UPDATE: Replace 2k with 1440p Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

localisation / translation Everything that has to do with translations or Weblate player Issues related to any player (main, popup and background) size/large PRs with less than 750 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants