Skip to content

Bugfix/bitmovin/ios fix updatecustomdata bridging #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvanlaerhoven merged 2 commits into from
Feb 25, 2026
Merged

Bugfix/bitmovin/ios fix updatecustomdata bridging #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3992b8
Use correct function name to bridge customData update logic
wvanhaevre Feb 25, 2026
0733d3c
Add changeset entry
wvanhaevre Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/real-papayas-glow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@theoplayer/react-native-analytics-bitmovin': patch
---

Fixed an issue on iOS where the updateCustomData method was not correctly bridged.
6 changes: 3 additions & 3 deletions bitmovin/ios/THEOplayerBitmovinRCTBitmovinAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ class THEOplayerBitmovinRCTBitmovinAPI: NSObject, RCTBridgeModule {
}
}

@objc(updateCustomMetadata:customData:)
func updateCustomMetadata(_ node: NSNumber, customData: NSDictionary) {
log("updateCustomMetadata triggered.")
@objc(updateCustomData:customData:)
func updateCustomData(_ node: NSNumber, customData: NSDictionary) {
log("updateCustomData triggered.")
DispatchQueue.main.async {
if let customMetadata = customData as? [String:Any] {
self.connectors[node]?.updateCustomMetadata(customMetadata)
Expand Down
2 changes: 1 addition & 1 deletion bitmovin/ios/THEOplayerBitmovinRCTBridge.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ @interface RCT_EXTERN_REMAP_MODULE(BitmovinModule, THEOplayerBitmovinRCTBitmovin

RCT_EXTERN_METHOD(updateSourceMetadata:(nonnull NSNumber *)node sourceMetadata:(nonnull NSDictionary *)sourceMetadata)

RCT_EXTERN_METHOD(updateCustomMetadata:(nonnull NSNumber *)node customData:(nonnull NSDictionary *)customData)
RCT_EXTERN_METHOD(updateCustomData:(nonnull NSNumber *)node customData:(nonnull NSDictionary *)customData)

RCT_EXTERN_METHOD(programChange:(nonnull NSNumber *)node sourceMetadata:(nonnull NSDictionary *)sourceMetadata)

Expand Down
Loading