Updated EntryPoint to allow for linux compilations

[AbduEhab]

The project works and compiles with my CMake version of the project which can be found here. It compiles on Ubuntu KDE. The changes should allow for macOS compilations too but I haven't tested them.

Summary by CodeRabbit

• Style
  • Improved consistency in function parameter spacing and namespace formatting in the main entry point.

[TheCherno]

@coderabbitai review

[coderabbitai]

Walkthrough

The recent update focuses on enhancing code readability and consistency across the project. It primarily addresses the formatting of function parameters and the structure of namespace blocks, ensuring uniformity and clearer code structure. This refinement aims at improving the development experience by making the codebase easier to navigate and understand.

Changes

File(s)	Summary of Changes
.../Walnut/EntryPoint.h	Adjusted spacing in function parameters; Reformatted namespace

🐰✨
In the realm of code, where clarity reigns,
A rabbit hopped, leaving behind neat lanes.
With every space and line, it took great care,
Ensuring consistency was present everywhere.
🌟 "To clearer code!" it joyously claims.
🥕🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 3b8e414 and feb08e2.

Files selected for processing (1)

• Walnut/src/Walnut/EntryPoint.h (3 hunks)

Additional comments not posted (4)

Walnut/src/Walnut/EntryPoint.h (4)

3-3: The declaration of Walnut::CreateApplication and the global variable g_ApplicationRunning are correctly placed and formatted.

---

6-13: The adjustments to the Main function's parameter spacing and the reformatting of the namespace block enhance code readability and consistency.

---

20-27: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [23-36]

The conditional compilation and structure of the main function for the Windows platform are correctly implemented and formatted.

---

42-48: The definition of the main function for non-Windows platforms is a key change for enabling Linux compilations, correctly implemented and formatted.

[AbduEhab]

Are there any plans to merge this?

[makredzic]

Stumbled on to this while attempting to create Walnut as a Meson build project instead of a CMAKE project.
Incredibly grateful to you @AbduEhab for sending this PR, I had zero energy to do this myself as I've been working on this Meson reconfiguration for Linux for hours.

If @TheCherno ever decides to provide support for other build systems such as Meson, I'm more than happy to send in a PR. Either way, I think merging this PR at least should be a no brainer.