Clarify that "errors" are not fatal #649
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakov-h
reviewed
Sep 1, 2025
| } | ||
|
|
||
| Console.WriteLine("Encountered error downloading depot manifest {0} {1}: {2}", depot.DepotId, depot.ManifestId, e.StatusCode); | ||
| Console.WriteLine("Encountered {2} for depot manifest {0} {1}. Retrying.", depot.DepotId, depot.ManifestId, e.StatusCode); |
Member
There was a problem hiding this comment.
Suggested change
| Console.WriteLine("Encountered {2} for depot manifest {0} {1}. Retrying.", depot.DepotId, depot.ManifestId, e.StatusCode); | |
| Console.WriteLine("Encountered HTTP {2:D} for depot manifest {0} {1}. Retrying.", depot.DepotId, depot.ManifestId, e.StatusCode); |
| { | ||
| cdnPool.ReturnBrokenConnection(connection); | ||
| Console.WriteLine("Encountered error downloading manifest for depot {0} {1}: {2}", depot.DepotId, depot.ManifestId, e.Message); | ||
| Console.WriteLine("Error downloading manifest for depot {0} {1}: {2} Retrying.", depot.DepotId, depot.ManifestId, e.Message); |
Member
There was a problem hiding this comment.
Suggested change
| Console.WriteLine("Error downloading manifest for depot {0} {1}: {2} Retrying.", depot.DepotId, depot.ManifestId, e.Message); | |
| Console.WriteLine("Error downloading manifest for depot {0} {1}: {2} Retrying...", depot.DepotId, depot.ManifestId, e.Message); |
| } | ||
|
|
||
| Console.WriteLine("Encountered error downloading chunk {0}: {1}", chunkID, e.StatusCode); | ||
| Console.WriteLine("Encountered {1} for chunk {0}. Retrying.", chunkID, e.StatusCode); |
Member
There was a problem hiding this comment.
Suggested change
| Console.WriteLine("Encountered {1} for chunk {0}. Retrying.", chunkID, e.StatusCode); | |
| Console.WriteLine("Encountered HTTP {1:D} for chunk {0}. Retrying...", chunkID, e.StatusCode); |
Author
There was a problem hiding this comment.
This is definitely not gonna be work out, because StatusCode is a value like ServiceUnavailable or NotFound from what I've observed.
Member
There was a problem hiding this comment.
Do you want the integer value (:D e.g. 503), or the enum name (:G eg ServiceUnavailable)?
Author
There was a problem hiding this comment.
I think Encountered ServiceUnavailable makes more sense and keeps it roughly identical to what it was. Encountered HTTP 503 doesn't mean a whole lot to anyone who hasn't studied the HTTP RFCs.
| { | ||
| cdnPool.ReturnBrokenConnection(connection); | ||
| Console.WriteLine("Encountered unexpected error downloading chunk {0}: {1}", chunkID, e.Message); | ||
| Console.WriteLine("Error downloading chunk {0}: {1} Retrying.", chunkID, e.Message); |
Member
There was a problem hiding this comment.
Suggested change
| Console.WriteLine("Error downloading chunk {0}: {1} Retrying.", chunkID, e.Message); | |
| Console.WriteLine("Error downloading chunk {0}: {1} Retrying...", chunkID, e.Message); |
Co-authored-by: Yaakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly the number one 'issue' I hear from users who are following our guides is that "DepotDownloader just throws a bunch of errors."
I've went ahead and refined the messages here based on the values I've observed (status codes always being an enumeration string, and exception messages always ending in a period).