Bug fix : instanceOf returns false #1273
Open
redoC-A2k wants to merge 2 commits intoSplidejs:masterfrom
Open
Conversation
|
@NaotoshiFujita could you already review this pull request? I have a problem which this request would fix. I render for a cms splide in an iframe and this isn't possible for chrome browsers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes #1272
Description
I tried to debug the issue , while debuggging I found out that even though splide_list element containing HTMLElement in prototype chain the isHTMLElement was returning false . I compared the two window variables one was iframe and other should be global window , but in grapesjs case the two window variables were same and I think that's why instanceOf might be returning false . When I used window.top instead of window isntanceOf returns true as expected .