Bug that autoplay stops when a click or drag event occurs while autoplay is enabled. ( #117 )#1151
Open
takky94 wants to merge 1 commit intoSplidejs:masterfrom
Open
Bug that autoplay stops when a click or drag event occurs while autoplay is enabled. ( #117 )#1151takky94 wants to merge 1 commit intoSplidejs:masterfrom
takky94 wants to merge 1 commit intoSplidejs:masterfrom
Conversation
…lay is enabled. ( Splidejs#117 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#117
Description
日本のかたのようなのでせっかくなので日本語でPR出させていただきます。
素敵なライブラリありがとうございます :)
重宝させていただいております。
関連Issueの通りですが、自分の環境でも上記Issueの問題が依然としてdocでも確認できました。(下記動画)
なお、こちらの症状ですがカルーセル範囲外をクリックすることでautoplayが再開することも確認済みです。
2023-04-12.21.33.13.mov
コード読む感じ、play関数の責務がPause状態からの復帰のようにも思えたので、別途関数を分けるような下記の修正のほうが好ましいのかもと思いつつ、これのためだけに関数1つ増やすのもどうなのかとも思ったので一旦この状態で出しておきます。
English
Since you seem to be from Japan, I'll put up a PR in Japanese.Thank you very much for your wonderful library :)
It is very useful.
I have been using it for a while now, but I still have the same problem as the above issue in my environment (see video below).
I have also confirmed that autoplay resumes by clicking outside the carousel area.
I read the code, and it seems that the responsibility of the play function is to recover from the pause state, so I thought it might be preferable to modify the code below to separate a separate function, but I also wondered if it would be a good idea to add a function just for this purpose, so I'll leave it as it is for now.
test suites
余談ですが npm install時に forceオプション付けてしまいました
.node-versionファイルかpackage.jsonにengine指定があると嬉しいです(node version起因でなければすみません🙇♂️)