Fix probe metadata and annotations retention#26
Fix probe metadata and annotations retention#26FrancescoNegri wants to merge 0 commit intoSpikeInterface:mainfrom FrancescoNegri:main
Conversation
|
Thanks @FrancescoNegri I fixed the tests. Can you merge with main? It should make tests pass here as well |
|
Sure @alejoe91! However, before merging, I wanted to fix the Do you think that making a new attribute |
Maybe :) |
|
@alejoe91 I noticed you added an optional |
Hi, everyone!
I noticed that when converting a probe from
probeinterface/Probetondx-probeinterface/Probeand then back toprobeinterface/Probesome metadata (name,manufacturer,serial_number,model_name) are lost.This is due to the
to_probeinterface()method and I fixed it by assigning these attributes to the newprobeinterface/Probeobject.More in general,
annotationsare not stored in thendx-probeinterface/Probeobject, thus they are not rewritten in the recoveredprobeinterface/Probeobject.Currently, this pull request fixes only the first issue concerning probe metadata, as they are saved as attributes of the
ndx-probeinterface/Probeobject. To my understanding, the retention ofannotationsin general would require some changes in thendx-probeinterface/Probeclass specification, making this task a bit more complex.