fix: change member variables visibility#56
Open
ld-codes wants to merge 1 commit intoSoftwareBrothers:masterfrom
Open
fix: change member variables visibility#56ld-codes wants to merge 1 commit intoSoftwareBrothers:masterfrom
ld-codes wants to merge 1 commit intoSoftwareBrothers:masterfrom
Conversation
dziraf
approved these changes
Mar 17, 2023
dziraf
approved these changes
Nov 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Change all private member variable visibility to protected so that library consumers can extend and switch adapter behavior to meet their needs.
I wanted to add support for soft deleted entities in our application but I wasn't able to customize the adapter because the classes have private members.