-
Notifications
You must be signed in to change notification settings - Fork 12
Add local integration test for graph store with heterogeneous datasets #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/integration_test |
GiGL Automation@ 22:04:40UTC : 🔄 |
mkolodner-sc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kyle! Generally LGTM -- just have a few small comments/questions. Also, have you been able to run this test locally?
python/tests/integration/distributed/graph_store/graph_store_integration_test.py
Show resolved
Hide resolved
python/tests/integration/distributed/graph_store/graph_store_integration_test.py
Outdated
Show resolved
Hide resolved
mkolodner-sc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kyle! LGTM provided it runs locally
Scope of work done
Sadly, we still need to disable this on cloud build - I can have a followup so this still runs locally.
I think it's still worth having the code in-place so that we can test this locally during dev. (and by we I mean me)
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO