Fix the recipe: makes Synthesic Sapphire's material data is Lapis Lazuli, fixing #3955#4309
Open
Outfit8TSB wants to merge 4 commits intoSlimefun:experimentalfrom
Open
Fix the recipe: makes Synthesic Sapphire's material data is Lapis Lazuli, fixing #3955#4309Outfit8TSB wants to merge 4 commits intoSlimefun:experimentalfrom
Outfit8TSB wants to merge 4 commits intoSlimefun:experimentalfrom
Conversation
fix the recipe by removing Lapis Lazuil and replacing it with another chemicals that form lapis lazuil. Real Life Lapis Lazuil's Chemical formula is (Na,Ca)8(AlSiO4)6(S,SO4,Cl)1-2). Calcite is CaCO3, it has calcium, Salt is Sodium Chloride(NaCl). Glass has AlSiO4.
Contributor
|
Your Pull Request was automatically labelled as: "✨ Fix" |
Outfit8TSB
changed the title
Capitalize Sulfate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
i fixed the synthesic sapphire issue, which cannot be used in workbench.
while researching the solution i found the Lapis's chemical formula. so i used it as a recipe.
Proposed changes
Added Calcite, Salt, Sulfate to it.
Changed the material to Minecraft's Lapis Lazuli.
Related Issues (if applicable)
Resolves #3955.
Checklist
I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).due to the big difference, calcite is not included in 1.17. so it only works on 1.17.NonnullandNullableannotations to my methods to indicate their behaviour for null values