chore(cli): always scaffold routes when creating new apps with the cli#3448
Draft
fredericoo wants to merge 4 commits intomainfrom
Draft
chore(cli): always scaffold routes when creating new apps with the cli#3448fredericoo wants to merge 4 commits intomainfrom
fredericoo wants to merge 4 commits intomainfrom
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
fredericoo
commented
Feb 6, 2026
Comment on lines
+8
to
+17
| <h2 id="mock-shop-notice-heading">Welcome to Hydrogen!</h2> | ||
| <p> | ||
| You’re seeing mocked products because no store is connected to | ||
| this project yet. | ||
| </p> | ||
| <p> | ||
| Link a store by running <code>npx shopify hydrogen link</code> in your | ||
| terminal. | ||
| </p> | ||
| </div> |
Contributor
Author
There was a problem hiding this comment.
these messages are inspired by this article
it’s a great read and helps writing better notification messages in general
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Improve the first-run experience by ensuring routes are always scaffolded and clearly communicating when the storefront is showing mocked data because no store is linked.
WHAT is this pull request doing?
HOW to test your changes?
npm run buildto build packagesnode packages/cli/dist/create-app.jsto verify it skips the setup step. this will scaffold a new app with routes. Starting the app should reveal the fully fledged app as we expect, with a welcome notice instructing you to link your storenode packages/cli/dist/create-app.js --no-routesto scaffold an app with no routes. Starting the app should display the virtual index route with instructions. I have not touched this in this PR.Checklist