fix: XGBoost model loading issue with modelcar in KServe deployments#2353
Open
Snomaan6846 wants to merge 1 commit intoSeldonIO:masterfrom
Open
fix: XGBoost model loading issue with modelcar in KServe deployments#2353Snomaan6846 wants to merge 1 commit intoSeldonIO:masterfrom
Snomaan6846 wants to merge 1 commit intoSeldonIO:masterfrom
Conversation
|
|
Author
|
Fix for #2352 |
Snomaan6846
force-pushed
the
opensource-master
branch
2 times, most recently
from
2b6f126 to
98b4a0e
Compare
Signed-off-by: Snomaan6846 <syedali@redhat.com> rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Snomaan6846
force-pushed
the
opensource-master
branch
from
98b4a0e to
01ee5cc
Compare
Snomaan6846
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: XGBoost model loading issue with modelcar in KServe deployments
Signed-off-by: Snomaan6846 syedali@redhat.com
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
Description :
The XGBoost library is not prepared to load model files from virtual filesystems (like /proc/$pid/root/... in case of modelcars). If we pass models as bytearrays to the XGBoost library (instead of file paths), the lib itself doesn't have to read the file. See dmlc/xgboost#11736 (comment) for the lib maintainers' insights.