Skip to content

build(deps): update github.com/Scalingo/go-scalingo to v10#1195

Merged
EtienneM merged 3 commits intomasterfrom
feat/pagination/json_tag
Mar 4, 2026
Merged

build(deps): update github.com/Scalingo/go-scalingo to v10#1195
EtienneM merged 3 commits intomasterfrom
feat/pagination/json_tag

Conversation

@EtienneM
Copy link
Member

@EtienneM EtienneM commented Mar 3, 2026

I tried a bunch of commands and they keep working

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@EtienneM EtienneM self-assigned this Mar 3, 2026
@EtienneM EtienneM force-pushed the feat/pagination/json_tag branch from 966030a to 0292695 Compare March 3, 2026 08:28
@EtienneM EtienneM changed the title build(deps): update github.com/Scalingo/go-scalingo to test pagination refacto build(deps): update github.com/Scalingo/go-scalingo to new major version Mar 3, 2026
@EtienneM EtienneM force-pushed the feat/pagination/json_tag branch 3 times, most recently from 6f4dfb4 to 7b8bc56 Compare March 3, 2026 15:41
@EtienneM EtienneM force-pushed the feat/pagination/json_tag branch from 7b8bc56 to fd73210 Compare March 3, 2026 15:42
@EtienneM EtienneM force-pushed the feat/pagination/json_tag branch 2 times, most recently from 87935fc to c8add97 Compare March 4, 2026 16:24
@EtienneM EtienneM changed the title build(deps): update github.com/Scalingo/go-scalingo to new major version build(deps): update github.com/Scalingo/go-scalingo to v10 Mar 4, 2026
@EtienneM EtienneM force-pushed the feat/pagination/json_tag branch from c8add97 to 5c42416 Compare March 4, 2026 16:24
@EtienneM EtienneM marked this pull request as ready for review March 4, 2026 16:24
@EtienneM EtienneM requested a review from a team as a code owner March 4, 2026 16:24
@EtienneM EtienneM requested review from sc-david-voisin and removed request for a team March 4, 2026 16:24
Copy link
Contributor

@sc-david-voisin sc-david-voisin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some code changes about pagination.
Did some of your tests cover some commands with pagination ?

Subsidiary question: what are the most significant changes from v9 to v10, and potentially impactful for cli ?

@EtienneM
Copy link
Member Author

EtienneM commented Mar 4, 2026

I see some code changes about pagination. Did some of your tests cover some commands with pagination ?

Yes I tested deployments which uses the pagination.

Subsidiary question: what are the most significant changes from v9 to v10, and potentially impactful for cli ?

You can look at the changes to apps/logs.go, deployments/list.go and db/backup_download.go for a representative view of the breaking changes. Impact is limited, mostly small signature changes. You can have a look at the last changelog entry for a comprehensive view of the changes: https://doc.scalingo.com/changelog

@EtienneM EtienneM requested a review from sc-david-voisin March 4, 2026 16:45
@sc-david-voisin
Copy link
Contributor

You can have a look at the last changelog entry for a comprehensive view of the changes: https://doc.scalingo.com/changelog

Nice!

Copy link
Contributor

@sc-david-voisin sc-david-voisin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EtienneM EtienneM merged commit 7dfa310 into master Mar 4, 2026
7 checks passed
@EtienneM EtienneM deleted the feat/pagination/json_tag branch March 4, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants