[onert] Fix Python typing for the benchmark_inference() function #16334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes Python typing for the benchmark_inference() function to correctly allow None as a value for the input_shapes parameter. This aligns the type hints with the actual implementation, which already handles None by falling back to shapes retrieved from the initialized session.
- Updated type annotation for
input_shapesparameter fromList[List[int]]toOptional[List[List[int]]] - Added
Optionalimport from thetypingmodule
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This commits fixes the typing by allowing passing None as a value for the input_shapes parameter in the benchmark_inference() function. In case of input_shapes being None, the function uses the shape retrieved from the initialized session. ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits fixes the typing by allowing passing None as a value for the
input_shapesparameter in thebenchmark_inference()function. In case ofinput_shapesbeingNone, the function uses the shape retrieved from the initialized session.ONE-DCO-1.0-Signed-off-by: Arkadiusz Bokowy [email protected]