Open
Conversation
iiuoon
reviewed
Nov 26, 2023
Comment on lines
104
to
105
| CC7D36DB2B04DA780069F109 /* SnapKit-Dynamic */, | ||
| ); |
Member
There was a problem hiding this comment.
스냅킷 추가하실 때 SnapKit-Dynamic말고 SnapKit 하나만 추가해주세요!
Comment on lines
+71
to
+72
| make.leading.equalTo(view.safeAreaLayoutGuide.snp.leading).offset(20) | ||
| make.trailing.equalTo(view.safeAreaLayoutGuide.snp.trailing).offset(-20) |
Member
There was a problem hiding this comment.
make.leading.trailing.equalTo(view.safeAreaLayoutGuide.snp.leading).inset(20) 한 줄로 가능합니다
Comment on lines
95
to
102
| @objc func backButtonTapped() { | ||
| guard let updatedMemo = createUpdatedMemo() else { | ||
| return | ||
| } | ||
|
|
||
| detailDelegate?.didUpdateDetailMemo(updatedMemo, atIndex: index!) | ||
| self.navigationController?.popViewController(animated: true) | ||
| } |
Member
There was a problem hiding this comment.
이 함수를 만들고 호출 안 해주고 있어서 데이터 전달에 문제가 있는 것 같아요
delegate는 MemoEditDelegate 사용하도록 수정해주세요!
Comment on lines
8
to
10
| protocol MemoDetailDelegate: AnyObject { | ||
| func didUpdateDetailMemo(_ memo: Memo, atIndex index: Int) | ||
| } |
Member
There was a problem hiding this comment.
backButtonTapped 함수에서 값을 이미 넘겨주기 때문에 이 delegate는 필요없을 것 같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Description
메모를 작성하고, 다시 들어가서 수정한 내용이 뷰컨트롤러에 업데이트가 되지 않아요,,ㅜㅜㅜ
📝 Progress