Skip to content

Conversation

@danlavu
Copy link

@danlavu danlavu commented Jan 23, 2026

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the sssd-test-framework dependency to a specific branch and enhances an existing IPA subid test case. The test case test_ipa__subids_configured is now parameterized to cover both provider=ipa and provider=ldap configurations, ensuring that SSSD can correctly read subid ranges in both scenarios. This improves the test coverage for subid functionality.

@danlavu
Copy link
Author

danlavu commented Jan 23, 2026

Depends on SSSD/sssd-test-framework@0b97f84

@danlavu danlavu force-pushed the tests-subids-ldap-config branch 4 times, most recently from 9e1a303 to 58cbc0c Compare January 27, 2026 03:29
@alexey-tikhonov
Copy link
Member

ldap-provider doesn't support subid ranges in sssd-2-11.
Also added 'blocked' while there is tmp commit.

@alexey-tikhonov
Copy link
Member

ImportError while loading conftest '/home/runner/work/sssd/sssd/sssd/src/tests/system/conftest.py'.
conftest.py:6: in <module>
    from sssd_test_framework.config import SSSDMultihostConfig
.venv/lib/python3.14/site-packages/sssd_test_framework/config.py:7: in <module>
    from .topology import SSSDTopologyMark
.venv/lib/python3.14/site-packages/sssd_test_framework/topology.py:125: in <module>
    class KnownTopology(KnownTopologyBase):
.venv/lib/python3.14/site-packages/sssd_test_framework/topology.py:139: in KnownTopology
    Client = SSSDTopologyMark(
.venv/lib/python3.14/site-packages/sssd_test_framework/topology.py:61: in __init__
    super().__init__(name, topology, fixtures)
E   TypeError: TopologyMark.__init__() takes 3 positional arguments but 4 were given
Error: Process completed with exit code 4.

@danlavu danlavu force-pushed the tests-subids-ldap-config branch from 58cbc0c to 788d58b Compare January 27, 2026 14:30
@alexey-tikhonov
Copy link
Member

ACK, but needs framework PR in.

@alexey-tikhonov alexey-tikhonov self-assigned this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants