gccrs: Fix empty struct constructors causing ICE during type checking #4342
+78
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-expr.cc (visit(StructExprStruct)): Update to properly unwrap enum variants for type checking. * typecheck/rust-tyty.cc (VariantDef::get_fields) : Remove NUM assert. * backend/rust-compile-expr.cc: Update to properly unwrap enum variants for type resolution checking. Signed-off-by: Yap Zhi Heng <[email protected]>
Polygonalr
force-pushed
the
issue-4163
branch
from
6bbea9f to
1919431
Compare
CohenArthur
approved these changes
Jan 2, 2026
Member
CohenArthur
left a comment
CohenArthur
left a comment
There was a problem hiding this comment.
This looks really good to me - I'll let @philberty review it as he knows the code more :) Thank you that's great work!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4163.