feat: add tag collection shortcut from post tags#103
feat: add tag collection shortcut from post tags#103AlejandroAkbal wants to merge 1 commit intomainfrom
Conversation
WalkthroughThe PostTag component now includes premium-gated tag collection functionality. A new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@components/pages/posts/post/PostTag.vue`:
- Around line 89-93: Replace the native prompt() call in PostTag.vue with the
app's custom modal flow: remove the prompt() usage around const name =
prompt('Enter a tag collection name')?.trim(), instead open the modal component
(e.g., TagCollectionModal or the existing useModal hook), await the modal
result, trim and validate the returned name, and keep the early-return behavior
if the user cancels or provides an empty value; update the code paths that use
the name so they read from the modal result rather than prompt().
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 036b821c-8b2f-4754-b6bb-9b18d27be0eb
📒 Files selected for processing (1)
components/pages/posts/post/PostTag.vue
| const name = prompt('Enter a tag collection name')?.trim() | ||
|
|
||
| if (!name) { | ||
| return | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider using a custom modal instead of prompt().
The native prompt() dialog is functional but provides a basic UX that doesn't match the app's styling. Consider using a modal component for better consistency with the rest of the UI.
This is a low-priority enhancement since the current implementation works correctly.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@components/pages/posts/post/PostTag.vue` around lines 89 - 93, Replace the
native prompt() call in PostTag.vue with the app's custom modal flow: remove the
prompt() usage around const name = prompt('Enter a tag collection
name')?.trim(), instead open the modal component (e.g., TagCollectionModal or
the existing useModal hook), await the modal result, trim and validate the
returned name, and keep the early-return behavior if the user cancels or
provides an empty value; update the code paths that use the name so they read
from the modal result rather than prompt().
Summary
Validation
pnpm exec vitest run test/pages/posts.test.ts(fails: missing existing@nuxt/test-utilsdependency in repo test setup)pnpm exec nuxi typecheck(fails with many pre-existing repo type errors and missing-module issues unrelated to this change)Feedback
Summary by CodeRabbit
Release Notes