Merged
Conversation
… bash -euo pipefail`. New shebang reports more errors in scripts and `set -e` in it already. So, no separate `set -e` in scripts' body is required. Changes: - Change shebang for the following scripts: - append_doc_feature.sh - append_info.sh - build_relm_docs.sh - fix_ssh.sh - Change shell from `#!/bin/sh` to `#!/usr/bin/env -S bash -euo pipefail` for build_relm_docs.sh script. Bash is nicer to write it.
Changes: - Use DIRSTACK (i.e. pushd/popd) instead of "cd" based directory traversal. - Replace several "mkdir" calls with a single "mkdir --parents" call to create several directories at one run. - Save a bit of bandwidth and time by not clonning full history of the repository. Instead clone only last commit of the tip of each branch, hence "--depth 1 --no-single-branch". - Replace repository URL of https://github.com/AaronErhardt/relm4 with https://github.com/Relm4/Relm4. It looks like the AaronErhardt/relm4 refer to some old repository and it doesn't exists anymore. - Replace checkout of "stable" branch with checkout of latest stable tag, e.g. v0.10.0. "stable" branch does not exist at Relm4/Relm4 repository anymore.
zekefast
added
documentation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Improve Bash scripts. Clean up inefficiencies. Fix cloned repository URL and checkouted branch.
Changes
append_doc_feature.shappend_info.shbuild_relm_docs.shfix_ssh.sh#!/bin/shto#!/usr/bin/env -S bash -euo pipefailforbuild_relm_docs.shscript. Bash is nicer to write.DIRSTACK(i.e.pushd/popd) instead ofcdbased directory traversal.mkdircalls with a singlemkdir --parentscall to create several directories at one run.--depth 1 --no-single-branch.https://github.com/AaronErhardt/relm4withhttps://github.com/Relm4/Relm4. It looks like theAaronErhardt/relm4refer to some old repository and it doesn't exists anymore.stablebranch with checkout of latest stable tag, e.g.v0.10.0.stablebranch does not exist atRelm4/Relm4repository anymore.