Adds an example of using the new columnar API to clone world.#138
Open
AngelOfSol wants to merge 1 commit intoRalith:masterfrom
Open
Adds an example of using the new columnar API to clone world.#138AngelOfSol wants to merge 1 commit intoRalith:masterfrom
AngelOfSol wants to merge 1 commit intoRalith:masterfrom
Conversation
Ralith
requested changes
Feb 15, 2021
| let mut writer = batch.writer::<T>().unwrap(); | ||
| for item in arch.get::<T>().unwrap().iter() { | ||
| if writer.push(item.clone()).is_err() { | ||
| panic!() |
Owner
There was a problem hiding this comment.
Suggested change
| panic!() | |
| unreachable!() |
| @@ -0,0 +1,142 @@ | |||
| use core::any::TypeId; | |||
Owner
There was a problem hiding this comment.
We should include module-level doc comments that explain what this demonstrates, why it's useful, why special effort is needed (there's no static guarantee that all components are Clone) and what the caveats are (unregistered components aren't cloned).
Contributor
Author
There was a problem hiding this comment.
Cool, I'll get on (I've not written an example before)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if you think I should make any changes to the example. I think it's a pretty good reference example of what you can do with the new API, though I'm curious if some sort of MapWorld<> API is reasonable as a better example.