Skip to content

Conversation

@ThomasNing
Copy link
Contributor

@ThomasNing ThomasNing commented Dec 25, 2025

Proposed changes

Fix the preshuffle regression of gfx950 and also make the modification to a ck tile internal math calling style.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@CongMa13
Copy link
Collaborator

CongMa13 commented Jan 6, 2026

The definition of divisor is the count of thread in k dimension in a warp tile.

So the unified formular could be

divisor = get_warp_size() / gemmConfig.N_Warp_Tile;
  • It is not affected by the value of K_Warp_Tile.
  • It is the same thing as WarpGemmAttributeMfmaImpl***::kABKLane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants