-
Notifications
You must be signed in to change notification settings - Fork 55
Some more documentation progress #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
... and 39 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
After the build completes, the updated documentation will be available here |
|
Thanks for the heroic effort @borisdevos , I will try to process all these comments tomorrow. |
|
Also, any general comments? What do you think of the new structure of the manual? Is it an improvement? |
|
It's a global improvement in my opinion. If I had to complain about some stylistic choice, there are certain paragraphs in the docs where a bunch of methods/properties are explained back-to-back, which can be bothersome to read through (although I don't know how often people really read paragraphs from start to finish and just ctrl+f words). In my opinion, one of the best-written parts is the fusion tree manipulations subsection, but maybe I'm just a big fan of lists. Another small remark: some paragraphs in the category theory introduction are also tough to read because there's some inconsistency with the maths written within the paragraph; some of it is not in some latex equation environment. Not a huge gripe, since this part is optional to read. But again, the pros outweigh these minor cons heavily, and the content remains rich and descriptive. I actually learnt/relearnt a lot going through the docs again 😄. |
|
I tried briefly skimming through the updates to just give some global comments, since it is a bit hard to interleave these/not duplicate the things @borisdevos has already marked (Thanks for the huge amount of work @borisdevos !!!) Considering the markdown formatting, I have also been advocating to indeed use a more "LaTeX" style for line breaks as well. I definitely like the division in more subpages, large pages make it quite hard to quickly jump to the wanted sections and to lose track of what is going on! One suggestion I have is about the order of these pages in the manual section. |
Co-authored-by: Boris De Vos <[email protected]>
Co-authored-by: Boris De Vos <[email protected]>
0e08554 to
a0ee325
Compare
a0ee325 to
8276c9c
Compare
|
I think I managed to resolve most of Boris' comments now, I wonder if it makes sense to simply go ahead and merge this in its current state. At least some of the sections that still refer to old factorization functions are now cleaned up, so we should put a little haste on this. |
This includes a major restructuring (breaking down long pages into separate pages) and a complete rewrite of the
Sectordocumentation. This could become the manual page for TensorKitSectors.jl in time, but for now I would still include it here.By lack of a good Markdown formatter, I switched to breaking lines at natural places (end of sentence, subsentences, …), like one might do with LaTeX documents. Maybe that strategy can lead to clean
git diffs in future (potentially smaller) doc changes, but I am open to other suggestions.This would very much benefit from some proofreading by e.g. @borisdevos , @leburgel , @lkdvos .