Disallow dual physical spaces for symmetries with non-trivial braiding#284
Merged
Yue-Zhengyuan merged 2 commits intomasterfrom Nov 6, 2025
Merged
Disallow dual physical spaces for symmetries with non-trivial braiding#284Yue-Zhengyuan merged 2 commits intomasterfrom
Yue-Zhengyuan merged 2 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Yue-Zhengyuan
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it's become apparent that our current implementations are likely incorrect for PEPS and PEPOs with dual physical spaces for symmetries with non-trivial braiding (see the discussions in #274 and #283), this explicitly disallows these configurations in the respective constructors until we've solved the underlying issues.