Clarify test assertion for UnitarySynthesis
#15489
Open
+13
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a rework of `UnitarySynthesis` I'm working on, I was (temporarily) failing this test, but didn't have much to go on because the failure message was just "False is not true". This commit changes the assertion to something more useful, so that the failing edges all appear in the output.
jakelishman
added
type: qa
Collaborator
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 20645984420Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a rework of
UnitarySynthesisI'm working on, I was (temporarily) failing this test, but didn't have much to go on because the failure message was just "False is not true". This commit changes the assertion to something more useful, so that the failing edges all appear in the output.Summary
Details and comments