-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/template 194 navigation3 #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ninovanhooff
wants to merge
19
commits into
develop
Choose a base branch
from
feature/template-194-navigation3
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2c47f7a
WIP navigation3
ninovanhooff e05e859
WIP failed attempt to pass navigation parameters
ninovanhooff ebcc340
FIX passing params to HomeSecond screen
ninovanhooff d348d64
ADD key to koinVM parameters even if not necessary
ninovanhooff ca7423e
FIX KoinCheckModulesTest
ninovanhooff 5570d0b
Merge remote-tracking branch 'origin/develop' into feature/template-1…
ninovanhooff 6a97947
FIX merge conflict
ninovanhooff cf56233
CHANGE use Koin dsl to provide params
ninovanhooff 2922cee
REMOVE unused navController
ninovanhooff 76642d8
REMOVE unused AppGraphRoutes.kt
ninovanhooff ea64991
ADD DeepLinkParser.kt for toplevel routes
ninovanhooff 7ee9c41
FIX could not go to Onboarding a second time
ninovanhooff 14fd165
ADD attribution to deeplink files
ninovanhooff 1bf686e
REMOVE unused navigation libs
ninovanhooff 8ad14af
FIX properly navigate from Onboarding to Home, clearing backstack
ninovanhooff c4a165b
Update core/navigation/src/main/kotlin/nl/q42/template/navigation/vie…
ninovanhooff 3f7390d
Update app/src/main/kotlin/nl/q42/template/navigation/deeplink/DeepLi…
ninovanhooff 50cf9aa
FIX deeplink char parsing
ninovanhooff 785f39a
REMOVE copilotDiffState.xml
ninovanhooff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
app/src/main/kotlin/nl/q42/template/navigation/HomeEntry.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| package nl.q42.template.navigation | ||
|
|
||
| import androidx.navigation3.runtime.EntryProviderScope | ||
| import androidx.navigation3.runtime.NavKey | ||
| import nl.q42.template.home.main.presentation.HomeViewModel | ||
| import nl.q42.template.home.main.ui.HomeScreen | ||
| import nl.q42.template.home.second.presentation.HomeSecondViewModel | ||
| import nl.q42.template.home.second.ui.HomeSecondScreen | ||
| import nl.q42.template.navigation.viewmodel.InitNavigator | ||
| import nl.q42.template.navigation.viewmodel.Navigator | ||
| import org.koin.androidx.compose.koinViewModel | ||
| import org.koin.core.parameter.parametersOf | ||
|
|
||
| internal fun EntryProviderScope<NavKey>.homeEntry(navigator: Navigator) { | ||
| entry<Destination.Home> { key -> | ||
| val viewModel: HomeViewModel = koinViewModel { parametersOf(key) } | ||
| InitNavigator(navigator = navigator, routeNavigator = viewModel) | ||
| HomeScreen(viewModel = viewModel) | ||
| } | ||
| entry<Destination.HomeSecond> { key -> | ||
| val viewModel: HomeSecondViewModel = koinViewModel { parametersOf(key) } | ||
| InitNavigator(navigator = navigator, routeNavigator = viewModel) | ||
| HomeSecondScreen(viewModel = viewModel) | ||
| } | ||
| } | ||
42 changes: 0 additions & 42 deletions
42
app/src/main/kotlin/nl/q42/template/navigation/HomeGraph.kt
This file was deleted.
Oops, something went wrong.
16 changes: 8 additions & 8 deletions
16
app/src/main/kotlin/nl/q42/template/navigation/OnboardingDestinations.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 98 additions & 0 deletions
98
app/src/main/kotlin/nl/q42/template/navigation/deeplink/DeepLinkMatcher.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| package nl.q42.template.navigation.deeplink | ||
|
|
||
| /** | ||
| * Source: https://github.com/android/nav3-recipes/blob/main/app/src/main/java/com/example/nav3recipes/deeplink/basic/util/DeepLinkMatcher.kt | ||
| */ | ||
|
|
||
| import android.util.Log | ||
| import androidx.navigation3.runtime.NavKey | ||
| import kotlinx.serialization.KSerializer | ||
| import nl.q42.template.navigation.Destination | ||
|
|
||
| internal class DeepLinkMatcher<T : Destination>( | ||
| val request: DeepLinkRequest, | ||
| val deepLinkPattern: DeepLinkPattern<T> | ||
| ) { | ||
| /** | ||
| * Match a [DeepLinkRequest] to a [DeepLinkPattern]. | ||
| * | ||
| * Returns a [DeepLinkMatchResult] if this matches the pattern, returns null otherwise | ||
| */ | ||
| fun match(): DeepLinkMatchResult<T>? { | ||
| if (request.uri.scheme != deepLinkPattern.uriPattern.scheme) return null | ||
| if (!request.uri.authority.equals( | ||
| deepLinkPattern.uriPattern.authority, | ||
| ignoreCase = true | ||
| ) | ||
| ) return null | ||
| if (request.pathSegments.size != deepLinkPattern.pathSegments.size) return null | ||
| // exact match (url does not contain any arguments) | ||
| if (request.uri == deepLinkPattern.uriPattern) | ||
| return DeepLinkMatchResult(deepLinkPattern.serializer, mapOf()) | ||
|
|
||
| val args = mutableMapOf<String, Any>() | ||
| // match the path | ||
| request.pathSegments | ||
| .asSequence() | ||
| // zip to compare the two objects side by side, order matters here so we | ||
| // need to make sure the compared segments are at the same position within the url | ||
| .zip(deepLinkPattern.pathSegments.asSequence()) | ||
| .forEach { it -> | ||
| // retrieve the two path segments to compare | ||
| val requestedSegment = it.first | ||
| val candidateSegment = it.second | ||
| // if the potential match expects a path arg for this segment, try to parse the | ||
| // requested segment into the expected type | ||
| if (candidateSegment.isParamArg) { | ||
| val parsedValue = try { | ||
| candidateSegment.typeParser.invoke(requestedSegment) | ||
| } catch (e: IllegalArgumentException) { | ||
| Log.e(TAG_LOG_ERROR, "Failed to parse path value:[$requestedSegment].", e) | ||
| return null | ||
| } | ||
| args[candidateSegment.stringValue] = parsedValue | ||
| } else if (requestedSegment != candidateSegment.stringValue) { | ||
| // if it's path arg is not the expected type, its not a match | ||
| return null | ||
| } | ||
| } | ||
| // match queries (if any) | ||
| request.queries.forEach { query -> | ||
| val name = query.key | ||
| // If the pattern does not define this query parameter, ignore it. | ||
| // This prevents a NullPointerException. | ||
| val queryStringParser = deepLinkPattern.queryValueParsers[name] ?: return@forEach | ||
|
|
||
| val queryParsedValue = try { | ||
| queryStringParser.invoke(query.value) | ||
| } catch (e: IllegalArgumentException) { | ||
| Log.e( | ||
| TAG_LOG_ERROR, | ||
| "Failed to parse query name:[$name] value:[${query.value}].", | ||
| e | ||
| ) | ||
| return null | ||
| } | ||
| args[name] = queryParsedValue | ||
| } | ||
| // provide the serializer of the matching key and map of arg names to parsed arg values | ||
| return DeepLinkMatchResult(deepLinkPattern.serializer, args) | ||
| } | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * Created when a requested deeplink matches with a supported deeplink | ||
| * | ||
| * @param [T] the backstack key associated with the deeplink that matched with the requested deeplink | ||
| * @param serializer serializer for [T] | ||
| * @param args The map of argument name to argument value. The value is expected to have already | ||
| * been parsed from the raw url string back into its proper KType as declared in [T]. | ||
| * Includes arguments for all parts of the uri - path, query, etc. | ||
| * */ | ||
| internal data class DeepLinkMatchResult<T : NavKey>( | ||
| val serializer: KSerializer<T>, | ||
| val args: Map<String, Any> | ||
| ) | ||
|
|
||
| const val TAG_LOG_ERROR = "Nav3RecipesDeepLink" |
36 changes: 36 additions & 0 deletions
36
app/src/main/kotlin/nl/q42/template/navigation/deeplink/DeepLinkParser.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package nl.q42.template.navigation.deeplink | ||
|
|
||
| import android.content.Intent | ||
| import android.net.Uri | ||
| import androidx.core.net.toUri | ||
| import nl.q42.template.navigation.Destination | ||
|
|
||
| internal val deepLinkPatterns: List<DeepLinkPattern<out Destination>> = listOf( | ||
| DeepLinkPattern( | ||
| uriPattern = "template://onboarding".toUri(), | ||
| serializer = Destination.Onboarding.serializer() | ||
| ) | ||
| ) | ||
|
|
||
| class DeeplinkParser { | ||
| fun parseIntent(intent: Intent): Destination? { | ||
| val uri: Uri? = intent.data | ||
| // associate the target with the correct backstack key | ||
| return uri?.let { | ||
| /** STEP 2. Parse requested deeplink */ | ||
| val request = DeepLinkRequest(uri) | ||
|
|
||
| /** STEP 3. Compared requested with supported deeplink to find match*/ | ||
| val match = deepLinkPatterns.firstNotNullOfOrNull { pattern -> | ||
| DeepLinkMatcher(request, pattern).match() | ||
| } | ||
| /** STEP 4. If match is found, associate match to the correct key*/ | ||
| match?.let { | ||
| //leverage kotlinx.serialization's Decoder to decode | ||
| // match result into a backstack key | ||
| KeyDecoder(match.args) | ||
| .decodeSerializableValue(match.serializer) | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.