win_psDscAdapter and psDscAdapter PScredentials fix for passing username and password #1308

mimachniak · 2025-12-08T22:15:46Z

PR Summary

I change creating object System.Management.Automation.PSCredential for ScriptBase resources base on Get-Credential parameters
Added dsc.yaml test file for ScriptBased DSC

PR Context

Fix using ScriptBased DSC resources when is reguired to use parameters with Get-Credentials

…aials

…nvert to System.Management.Automation.PSCredentia

mimachniak · 2025-12-09T06:38:35Z

@microsoft-github-policy-service agree

@mimachniak please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree

adapters/powershell/psDscAdapter/win_psDscAdapter.psm1

Gijsreyn · 2025-12-14T07:38:13Z

@mimachniak - as I have already spoken with you on socials, is this perhaps also possible for class-based DSC resources (both in the 5.1 and 7.0 adapter)? Can you also include a testcase that covers this change?

mimachniak · 2025-12-14T13:09:06Z

Yes I working o it

…x-ScriptDSC

…rt to System.Management.Automation.PSCredentia - code optimalization remove unused function

…tem.Management.Automation.PSCredential

…meters

…t to System.Management.Automation.PSCredential

…t to System.Management.Automation.PSCredential - if change to recognize user information

mimachniak · 2025-12-18T09:58:40Z

@Gijsreyn , @SteveL-MSFT - I added in test folder yaml's that are using TestClass for validation using PSCredentials, I tested on version 5.1 and 7 of PowerShell

Gijsreyn · 2025-12-21T03:32:04Z

@mimachniak - can it be tested inside the powershellgroup.config.tests.ps1 and win_powershellgroup.tests.ps1 or is it already covered?

mimachniak · 2025-12-21T09:37:10Z

@mimachniak - can it be tested inside the powershellgroup.config.tests.ps1 and win_powershellgroup.tests.ps1 or is it already covered?

I will add today, I added yaml files for running test

…alid secure object

mimachniak · 2025-12-21T21:45:22Z

@mimachniak - can it be tested inside the powershellgroup.config.tests.ps1 and win_powershellgroup.tests.ps1 or is it already covered?

I added unit test and validation in file in powershellgroup.config.tests.ps1

…d secure object

mimachniak · 2025-12-22T21:36:15Z

I added test for 5.1 as well

adapters/powershell/psDscAdapter/win_psDscAdapter.psm1

SteveL-MSFT · 2026-01-12T18:12:43Z

@mimachniak Thanks for adding the test resource, but there isn't a Pester test using it yet?

mimachniak · 2026-01-12T18:51:37Z

@SteveL-MSFT I will add test today

…sc for script resources

… parameters - credentials

…ameters - credentials

mimachniak · 2026-01-13T11:06:17Z

@SteveL-MSFT I will add test today

Test added and minor fix to adapter as well

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot · 2026-01-14T00:29:14Z

adapters/powershell/psDscAdapter/win_psDscAdapter.psm1

+                                $_.Value.Password
+
+                            if (-not $hasSecureCred -and -not $hasTextCred) {
+                                "$($_.Value)" | Write-DscTrace -Operation Warn


The debug log statement here appears to be logging the entire credential object value, which could potentially expose sensitive information like passwords in debug logs. Consider logging only non-sensitive metadata about the credential (like its type or name) rather than the full value.

Copilot · 2026-01-14T00:29:15Z

adapters/powershell/psDscAdapter/psDscAdapter.psm1

+                                    $_.Value.Password
+
+                                    if (-not $hasSecureCred -and -not $hasTextCred) {
+                                        "$($_.Value)" | Write-DscTrace -Operation Warn


The debug log statement here appears to be logging the entire credential object value, which could potentially expose sensitive information like passwords in debug logs. Consider logging only non-sensitive metadata about the credential (like its type or name) rather than the full value.

Suggested change

"$($_.Value)" | Write-DscTrace -Operation Warn

"Invalid credential object for property '$($_.Name)'" | Write-DscTrace -Operation Warn

Copilot · 2026-01-14T00:29:15Z

adapters/powershell/psDscAdapter/win_psDscAdapter.psm1

+                                    [System.Management.Automation.PSCredential]::new($username, $password)
+                            }
+
+


There is trailing whitespace on this line. This should be removed to maintain code cleanliness.

Suggested change

mimachniak · 2026-01-14T08:28:43Z

@SteveL-MSFT I see that I need to add to test in script base module creation, I will do it today

SteveL-MSFT · 2026-01-14T18:38:29Z

@mimachniak Some Windows Pester tests failed in CI, can you take a look at those? Also look over the Copilot feedback and see if any should be addressed. Thanks!

mimachniak · 2026-01-14T22:35:35Z

@mimachniak Some Windows Pester tests failed in CI, can you take a look at those? Also look over the Copilot feedback and see if any should be addressed. Thanks!

Yes I'm fixing this as well

mimachniak added 2 commits December 8, 2025 22:45

Add to win_psDscAdapter function for extraxting string from PSCredent…

61f4b85

…aials

Add to win_psDscAdapter for ScriptBase resources PSCredentails fix co…

cd5df41

…nvert to System.Management.Automation.PSCredentia

Gijsreyn reviewed Dec 14, 2025

View reviewed changes

adapters/powershell/psDscAdapter/win_psDscAdapter.psm1 Outdated Show resolved Hide resolved

mimachniak and others added 3 commits December 17, 2025 16:26

Merge branch 'PowerShell:main' into win_psDscAdapter-PSCredentials-fi…

98e7099

…x-ScriptDSC

Fix win_psDscAdapter for ScriptBase resources PSCredentails fix conve…

0a7c6aa

…rt to System.Management.Automation.PSCredentia - code optimalization remove unused function

psDscAdapter for ClassBase resources PSCredentails fix convert to Sys…

82aeec4

…tem.Management.Automation.PSCredential

mimachniak changed the title ~~Win ps dsc adapter ps credentials fix script dsc~~ win_psDscAdapter and psDscAdapter PScredentials fix for passing username and password Dec 18, 2025

mimachniak added 3 commits December 18, 2025 10:30

Add for testClass testing yaml with secureObject - main file and para…

506ba9f

…meters

Fix win_psDscAdapter for ClassBase resources PSCredentails fix conver…

49c381c

…t to System.Management.Automation.PSCredential

Fix win_psDscAdapter for ClassBase resources PSCredentails fix conver…

403e6b5

…t to System.Management.Automation.PSCredential - if change to recognize user information

Ad unit test for credentaials in powershellgroup.config.tests.ps1 - v…

352dd69

…alid secure object

mimachniak added 2 commits December 22, 2025 22:30

Ad unit test for credentaials in win_powershellgroup.tests.ps1 - vali…

4af004e

…d secure object

Ad unit test for credentaials in win_powershellgroup.tests.ps1 - vali…

dd7425e

…d secure object

SteveL-MSFT requested changes Jan 7, 2026

View reviewed changes

adapters/powershell/psDscAdapter/win_psDscAdapter.psm1 Outdated Show resolved Hide resolved

Add script base DSC resources for testing credentials

b8cff4a

johlju mentioned this pull request Jan 12, 2026

SqlDatabase: Error: JSON: expected value at line 1 column 1 dsccommunity/SqlServerDsc#2403

Open

mimachniak added 4 commits January 13, 2026 00:21

Add script base DSC resources for testing credentials and fix win_PsD…

63cd935

…sc for script resources

Script base yaml DSC resources for credential valid

73dacde

Add script base resource test in win_powershellgroup.tests.ps1

34b6b73

Add to win_psDscAdapter.psm1 support for secure object and test value…

877ee8b

… parameters - credentials

Add to psDscAdapter.psm1 support for secure object and test value par…

7984d06

…ameters - credentials

Change faild test win_powershellgroup.tests it false

661259b

SteveL-MSFT requested a review from Copilot January 14, 2026 00:25

Copilot started reviewing on behalf of SteveL-MSFT January 14, 2026 00:25 View session

Copilot AI reviewed Jan 14, 2026

View reviewed changes

	"$($_.Value)" \| Write-DscTrace -Operation Warn
	"Invalid credential object for property '$($_.Name)'" \| Write-DscTrace -Operation Warn

		[System.Management.Automation.PSCredential]::new($username, $password)
		}

win_psDscAdapter and psDscAdapter PScredentials fix for passing username and password #1308

Are you sure you want to change the base?

win_psDscAdapter and psDscAdapter PScredentials fix for passing username and password #1308

Uh oh!

Conversation

mimachniak commented Dec 8, 2025

PR Summary

PR Context

Uh oh!

mimachniak commented Dec 9, 2025

Uh oh!

Uh oh!

Gijsreyn commented Dec 14, 2025

Uh oh!

mimachniak commented Dec 14, 2025

Uh oh!

mimachniak commented Dec 18, 2025

Uh oh!

Gijsreyn commented Dec 21, 2025

Uh oh!

mimachniak commented Dec 21, 2025

Uh oh!

mimachniak commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mimachniak commented Dec 22, 2025

Uh oh!

Uh oh!

SteveL-MSFT commented Jan 12, 2026

Uh oh!

mimachniak commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mimachniak commented Jan 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

mimachniak commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveL-MSFT commented Jan 14, 2026

Uh oh!

mimachniak commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mimachniak commented Dec 21, 2025 •

edited

Loading

mimachniak commented Jan 12, 2026 •

edited

Loading

mimachniak commented Jan 14, 2026 •

edited

Loading