Fix VA TANF max payment cap scaling and enhance references#7501
Draft
hua7450 wants to merge 2 commits intoPolicyEngine:mainfrom
Draft
Fix VA TANF max payment cap scaling and enhance references#7501hua7450 wants to merge 2 commits intoPolicyEngine:mainfrom
hua7450 wants to merge 2 commits intoPolicyEngine:mainfrom
Conversation
The max reimbursable payment cap was not being multiplied by the standard_multiplier, causing underpayment for large families in post-2020 simulations. Also fixes 2 wrong PDF page numbers, adds 4 missing budget amendment citations, and adds missing federal citation for dependent care deduction. Closes PolicyEngine#7500 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hua7450
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7501 +/- ##
===========================================
+ Coverage 97.82% 100.00% +2.17%
===========================================
Files 3 1 -2
Lines 92 25 -67
Branches 2 0 -2
===========================================
- Hits 90 25 -65
+ Misses 1 0 -1
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the VA TANF max reimbursable payment cap scaling bug and improves reference quality across parameter files.
Closes #7500
Changes
Bug Fix: Max Payment Cap Scaling (
va_tanf.py)The max reimbursable payment cap was looked up at base (2020-10-01) values but not multiplied by
standard_multiplier, while the grant standard was correctly scaled. This caused underpayment for large families in post-2020 simulations where the scaled grant exceeded the unscaled cap.4 new cap tests added covering all combinations (Group II/III × TANF/TANF-UP).
Reference Fixes (4 parameter files)
grant_standard/group3/addition.yamlandup_grant_standard/group3/addition.yaml— changed#page=25→#page=26standard_multiplier.yaml: HB1400 (2016 +2.5%), SB1100 (2019 +5%), HB30 (2020 +15%), HB1800 (2021 +10%)dependent_care/full_time.yaml: 45 CFR 233.20(a)(11)(i)(B)Verification
Regulatory Sources
Test Plan
make formatclean🤖 Generated with Claude Code