BMW and FIELDLINES-style output formatting for B_plasma calculations#1883
Draft
maya-avida wants to merge 104 commits intodd/B_plasmafrom
Draft
BMW and FIELDLINES-style output formatting for B_plasma calculations#1883maya-avida wants to merge 104 commits intodd/B_plasmafrom
maya-avida wants to merge 104 commits intodd/B_plasmafrom
Conversation
…ons, which first calculates the vector potential and then the curl to ensure a divergence-free magnetic field.
…eed to implement guardrails to ensure the evaluation point is outside the plasma boundary
…entation of divergence computation.
…s designed to extend flux coordinates beyond plasma boundary. Tiny modification to compute/nabla.
…3D RPZ grid by default
… tensor computations
…nabla, and equilibrium
…e difference between the output oof eq.compute(kernel.keys, grid=source_grid,override_grid=True) and override_grid=False is negligible.
… line integration again)
…and vector potential calculations. Also, documentation for RPZ transforms.
…x via merge with master
no need to enforce symmetry since symmetry is always false
…gnetic field from equilibrium
Addresses #1749 --------- Co-authored-by: Greta Hibbard <gh7283@della-gpu.princeton.edu> Co-authored-by: Rahul Gaur <19224702+rahulgaur104@users.noreply.github.com> Co-authored-by: Rahul <rgaur@terpmail.umd.edu> Co-authored-by: Greta Hibbard <gh7283@della9.princeton.edu> Co-authored-by: Rory Conlin <wconlin@princeton.edu> Co-authored-by: Dario Panici <37969854+dpanici@users.noreply.github.com> Co-authored-by: Yigit Gunsur Elmacioglu <102380275+YigitElma@users.noreply.github.com>
Progress toward addressing #1154. The [attached benchmark](https://github.com/user-attachments/files/21745848/benchmark_partial_sum.zip) must be ran on `ku/nufft` branch. 250x speed improvement from ~15 seconds to ~50 milliseconds. The improvement would be more if the FourierZernike basis is padded as discussed in #1243. Then we would avoid the 3D spectral to real transform as well as N^2 FFTs of size N. (Then this computation would likely be in microsecond range).
fixed docstring for compute_magnetic_grid
…er method control fix to plasma_field that prevents the phi coordinates from being reordered errors from wrong basis bug fix squash this later squash this too
…rvation that basis='xyz' previously did not work for virtual casing method
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
|
If you can merge the base |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.