Draft: introduce a warning for Arms without any Solids#1
Open
roselandgoose wants to merge 1 commit intoPhilippe117:masterfrom
Open
Draft: introduce a warning for Arms without any Solids#1roselandgoose wants to merge 1 commit intoPhilippe117:masterfrom
roselandgoose wants to merge 1 commit intoPhilippe117:masterfrom
Conversation
|
It would be more user-friendly if the script automatically accounted for the solids in rotors, etc. I'm sure there's some technical reason why it doesn't, but if not then it would make more sense and address this issue too. |
Author
|
I agree on all points. Assuming that there is a technical reason why MArmOS doesn't already do this automatically, perhaps a compromise might add a constructor argument like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have on at least three different occasions returned to using MArmOS after a significant time and made this exact mistake. That is, I've forgotten that Rotors, Hinges, and Pistons do not account for their block's physical size, just like Kyr.
This PR introduces a check for any Solids in the Arm at all, issuing a warning if none are found.
This PR is only a draft meant to get feedback from you on the idea - I haven't even tried compiling it yet. Let me know if this is something you're interesting in.
I've added the check to the UserControl constructor, but perhaps you would prefer it elsewhere. I've used a recursive method on the Hardware class, but maybe you'd rather add a method to the interface. And so on...
Thanks for the great script! Looking forward to your response.