Skip to content

Draft: introduce a warning for Arms without any Solids#1

Open
roselandgoose wants to merge 1 commit intoPhilippe117:masterfrom
roselandgoose:master
Open

Draft: introduce a warning for Arms without any Solids#1
roselandgoose wants to merge 1 commit intoPhilippe117:masterfrom
roselandgoose:master

Conversation

@roselandgoose
Copy link

I have on at least three different occasions returned to using MArmOS after a significant time and made this exact mistake. That is, I've forgotten that Rotors, Hinges, and Pistons do not account for their block's physical size, just like Kyr.

This PR introduces a check for any Solids in the Arm at all, issuing a warning if none are found.

This PR is only a draft meant to get feedback from you on the idea - I haven't even tried compiling it yet. Let me know if this is something you're interesting in.

I've added the check to the UserControl constructor, but perhaps you would prefer it elsewhere. I've used a recursive method on the Hardware class, but maybe you'd rather add a method to the interface. And so on...

Thanks for the great script! Looking forward to your response.

@hades200082
Copy link

It would be more user-friendly if the script automatically accounted for the solids in rotors, etc.

I'm sure there's some technical reason why it doesn't, but if not then it would make more sense and address this issue too.

@roselandgoose
Copy link
Author

I agree on all points. Assuming that there is a technical reason why MArmOS doesn't already do this automatically, perhaps a compromise might add a constructor argument like AddSolid for rotors, etc. If it was disabled by default, it wouldn't break existing Arms with user-provided solids. But at least the steam guide could encourage its use in the "Basic" section for new/infrequent users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants