This repository was archived by the owner on Aug 19, 2021. It is now read-only.
SAAS-175 Add tests for auth API #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| func TestPermissionsForSTTChecksPage(t *testing.T) { | ||
| func TestPermissions(t *testing.T) { |
There was a problem hiding this comment.
[golangci-lint] reported by reviewdog 🐶
Function 'TestPermissions' is too long (80 > 60) (funlen)
4 tasks
artemgavrilov
commented
Jul 16, 2020
Gopkg.toml
Outdated
| [[constraint]] | ||
| name = "github.com/percona/pmm" | ||
| branch = "PMM-2.0" | ||
| branch = "SAAS-175-auth-api" |
palash25
reviewed
Jul 20, 2020
palash25
reviewed
Jul 20, 2020
Contributor
palash25
left a comment
palash25
left a comment
There was a problem hiding this comment.
We have two auth_test files in the server directory, maybe we should have top level comments explaining what kind of authentication do they tests for in each of those files
palash25
reviewed
Jul 21, 2020
AlekSi
approved these changes
Jul 23, 2020
palash25
approved these changes
Jul 23, 2020
BupycHuk
approved these changes
Jul 27, 2020
artemgavrilov
changed the title
|
|
||
| // Tests in this file cover Percona Platform authentication. | ||
|
|
||
| func TestPlatform(t *testing.T) { |
There was a problem hiding this comment.
[golangci-lint] reported by reviewdog 🐶
Function 'TestPlatform' is too long (127 > 60) (funlen)
artemgavrilov
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/SAAS-175
SAAS-175 Auth API percona/pmm-managed#420
SAAS-175 Auth API percona/pmm#553
Feature build: Percona-Lab/pmm-submodules#967