JOSS manuscript #265
JOSS manuscript #265
Conversation
for more information, see https://pre-commit.ci
|
Thanks @iuryt, this is great! Your changes definitely help a lot with readability. My only subsequent change is that I prefer the colorbars to match the horizontal extent of the subplots, so I have removed 
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Hi all, happy New Year! As a reminder, please do give your approval to this PR when you're happy for me to submit to JOSS ✅ |
ammedd
left a comment
ammedd
left a comment
There was a problem hiding this comment.
Whoops, went ahead and pushed some changes I should have written as comments. Just compare and keep what you like. Looks good!
No worries - the changes look good, thanks! I have changed @surgura's affiliation back to FI though as I believe they paid for his work, according to @erikvansebille's previous comment. |
Indeed, @surgura was paid through the FI as far as I know |
This PR is for visibility of a draft of the VirtualShip JOSS manuscript, and for the review as co-authors to be organised here.
Feel free to add comments and commits to this PR, or branch off as new PRs for suggested changes.
@VeckoTheGecko @iuryt @surgura you have all made substantial contributions to the code. I have listed you as co-authors, alongside @ammedd and @erikvansebille. In the first place, are you happy to be involved with the manuscript? If so, please also let me know what kind of timeline I can expect to get your feedback!