Enable Commit with force without partial#604
Open
pavelrn wants to merge 3 commits intoPaloAltoNetworks:developfrom
Open
Enable Commit with force without partial#604pavelrn wants to merge 3 commits intoPaloAltoNetworks:developfrom
force without partial#604pavelrn wants to merge 3 commits intoPaloAltoNetworks:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow a
forcecommit for the whole configuration, i.e., withoutpartial.Motivation and Context
If you do
load config fromin PAN-OS, the system requires aforcecommit for the whole configuration. Attempting to doforcewithpartialtriggers an error.In the previous code version, setting
forceflag automatically makes a commitpartialthat I believe is wrong.How Has This Been Tested?
Tested in PAN-OS 11.x as part of the Ansible playbook.
Screenshots (if appropriate)
Types of changes
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist