feat(network.StaticRoute): conditions and none value nexthop_type#578
Open
alperenkose wants to merge 1 commit intoPaloAltoNetworks:developfrom
Open
feat(network.StaticRoute): conditions and none value nexthop_type#578alperenkose wants to merge 1 commit intoPaloAltoNetworks:developfrom
alperenkose wants to merge 1 commit intoPaloAltoNetworks:developfrom
Conversation
Add conditions to StaticRoute nexthop and nexthop_type params as well as accepting 'none' value as an input for nexthop_type.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add conditions to
StaticRoutenexthop and nexthop_type params as well as accepting 'none' value as an input for nexthop_type.Motivation and Context
Providing
Nonevs a'none'string tonexthop_typeparam inpan-os-ansiblepanos_static_route module cause different behaviour. ProvidingNone(meaning no value is provided) means to use the default value of the object on present/merged states whereas providing a'none'value means to set the nexthop_type to "None" in panos.This is causing an issue with a recent change in pan-os-ansible where it fetches default values from pan-os-python sdk while creating or updating objects with None value params. With this change pan-os-python can also accept "none" str value for nexthop_type as well as structure the xml depending on the nexthop_type via conditions.
This is NOT a breaking change since it's still possible to use
StaticRouteclass withnexthop_typeandnexthopset toNonein order to produce "None" next hop type in panos xml.How Has This Been Tested?
Tested live on VMSeries firewalls as well as with the written integration tests.
Types of changes
Checklist