Open
Conversation
FliesLikeABrick
approved these changes
May 21, 2024
|
@shinmog @btorresgil long time no talk - would either of you be available for review? |
adambaumeister
approved these changes
May 21, 2025
Collaborator
adambaumeister
left a comment
adambaumeister
left a comment
There was a problem hiding this comment.
Looks correct to me based on our other codebases, @horiagunica if you've got a firewall running in HA mode can you just double check?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
During testing and attempts to create HA pairs during initialization of a device tree from Panorama, I noticed that I was unable to get the HA peer serial, and after some investigation I found that this path was incorrect from the XML I was able to test against.
How Has This Been Tested?
This has been run against an environment with several Panorama and Firewall devices on PAN-OS 10.2.
Types of changes
Checklist