added vartype='member' to BgpPolicyRule:action_community_argument#233
Open
steve-krause wants to merge 1 commit intoPaloAltoNetworks:developfrom
Open
added vartype='member' to BgpPolicyRule:action_community_argument#233steve-krause wants to merge 1 commit intoPaloAltoNetworks:developfrom
steve-krause wants to merge 1 commit intoPaloAltoNetworks:developfrom
Conversation
Contributor
Author
|
I am not sure why this pull request hasn't been looked at and approved. We have made the change and used it successfully a number of times in our environment. Please let me know if I need to take action to move this forward. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added vartype='member' to the BgpPolicyRule class parameter 'action_community_argument' in network.py
Description
I changed the vartype to "member" in order to correctly parse a template with the BgpPolicyRule action_community set to append and an argument of 65100:1
Motivation and Context
I was unable to make any changes to the BGP configuration of the virtual-router because our template had an community_action set to append with an argument of 65100:1. Whenever I tried to make a change to certain sections of config under the virtual-router I would receive an error.
How Has This Been Tested?
I am now able to successfully parse and change the virtual-router section of the templates in question without errors
Screenshots (if appropriate)
Types of changes
changes the way the BgpPolicyRule community_action_argument is deployed on the device
Checklist