⚙️ [Maintenance]: Implement PR Supersedence for Font Data Updater#147
⚙️ [Maintenance]: Implement PR Supersedence for Font Data Updater#147MariusStorhaug merged 17 commits intomainfrom
Conversation
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
|
@copilot Remember to put all scripts from workflows into powershell scripts in the scripts folder and call these files from the task in the workflow. Also, change the |
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Done! The changes have been implemented in commit a4857ab:
The workflow now calls |
The Update-FontsData.ps1 script already closes superseded Auto-Update PRs immediately after creating a new one, making the separate cleanup workflow (triggered on PR merge) redundant.
No Significant Changes DetectedThis PR does not contain changes to files that would trigger a new release:
Build, test, and publish stages will be skipped for this PR. If you believe this is incorrect, please verify that your changes are in the correct locations. |
No Significant Changes DetectedThis PR does not contain changes to files that would trigger a new release:
Build, test, and publish stages will be skipped for this PR. If you believe this is incorrect, please verify that your changes are in the correct locations. |
No Significant Changes DetectedThis PR does not contain changes to files that would trigger a new release:
Build, test, and publish stages will be skipped for this PR. If you believe this is incorrect, please verify that your changes are in the correct locations. |
No Significant Changes DetectedThis PR does not contain changes to files that would trigger a new release:
Build, test, and publish stages will be skipped for this PR. If you believe this is incorrect, please verify that your changes are in the correct locations. |
No Significant Changes DetectedThis PR does not contain changes to files that would trigger a new release:
Build, test, and publish stages will be skipped for this PR. If you believe this is incorrect, please verify that your changes are in the correct locations. |
No Significant Changes DetectedThis PR does not contain changes to files that would trigger a new release:
Build, test, and publish stages will be skipped for this PR. If you believe this is incorrect, please verify that your changes are in the correct locations. |
There was a problem hiding this comment.
Pull request overview
Implements Dependabot-like PR supersedence for the font data updater so that when a new auto-update PR is created, older open Auto-Update* PRs are automatically commented on and closed. Adds documentation for the updater workflow and its supersedence behavior (Fixes #146).
Changes:
- Add logic to
scripts/Update-FontsData.ps1to locate the newly created PR, find other openAuto-Update*PRs, comment on them, and close them. - Add
scripts/README.mddocumenting the updater workflow, configuration, and troubleshooting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/Update-FontsData.ps1 | Adds post-PR-creation logic to comment on and close superseded Auto-Update* PRs. |
| scripts/README.md | Documents the updater script’s behavior, including PR supersedence and operational details. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Run gh pr comment $pr.number --repo 'PSModule/GoogleFonts' --body $comment | ||
|
|
||
| # Close the PR | ||
| Run h pr close $pr.number --repo 'PSModule/GoogleFonts' |
There was a problem hiding this comment.
Typo in command invocation: Run h pr close ... calls h instead of gh, which will fail with “command not found” and abort the workflow when trying to close superseded PRs. Update it to invoke the GitHub CLI (gh pr close).
| Run h pr close $pr.number --repo 'PSModule/GoogleFonts' | |
| Run gh pr close $pr.number --repo 'PSModule/GoogleFonts' |
No Significant Changes DetectedThis PR does not contain changes to files that would trigger a new release:
Build, test, and publish stages will be skipped for this PR. If you believe this is incorrect, please verify that your changes are in the correct locations. |
No Significant Changes DetectedThis PR does not contain changes to files that would trigger a new release:
Build, test, and publish stages will be skipped for this PR. If you believe this is incorrect, please verify that your changes are in the correct locations. |
No Significant Changes DetectedThis PR does not contain changes to files that would trigger a new release:
Build, test, and publish stages will be skipped for this PR. If you believe this is incorrect, please verify that your changes are in the correct locations. |
The font data updater now automatically closes older Auto-Update pull requests when a new update is created, similar to Dependabot's supersedence behavior. This keeps your repository tidy by ensuring only the most recent font data update PR remains open.
PR Supersedence Behavior
When the font data updater creates a new Auto-Update PR, it now automatically:
Auto-Update*PRsThe comment posted on superseded PRs references the new PR number:
Documentation
A new
scripts/README.mddocuments: